Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 26 Apr 2025 16:42:56 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Avoid circular header file dependency
Message-ID: <aAyOgHY7IXN7GQFv@paquier.xyz>
References: <aAxQ6fcY5QQV1lo3@ip-10-97-1-34.eu-west-3.compute.internal>
 <2238517.1745644856@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Sr1M8wF/ywytFm6j"
Content-Disposition: inline
In-Reply-To: <2238517.1745644856@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/aAyOgHY7IXN7GQFv%40paquier.xyz>
Precedence: bulk


--Sr1M8wF/ywytFm6j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 26, 2025 at 01:20:56AM -0400, Tom Lane wrote:
> Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:
>> While working on wait events I faced some compilation issues due to circ=
ular
>> header file dependency (introduced in fa88928470b5) between wait_event.h=
 and
>> wait_event_types.h.
>=20
> Ugh.  I still carry the scars of cleaning up after a previous
> circular-inclusion mess (cf 1609797c2), so I'm always worried about
> introducing new cases.  I don't have an opinion about whether this
> specific refactoring is the best way to deal with this case, but
> I definitely feel that we mustn't allow the situation to persist.

This one is my fault, so I'll take care of it.  Splitting the values
of the wait classes into their own header makes sense, but the header
name wait_class_constants.h sounds a bit off.  Why not a simpler
"wait_classes.h" that gets included by wait_event.h and
wait_event_types.h?
--
Michael

--Sr1M8wF/ywytFm6j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmgMjoAACgkQnvQgOdby
QH2JuQ/7BkH3pMaTWM+V2qAzqQM9ba7jSSC/Eyr50zorzKXBA15yEMCyG/NN9gh7
KIxqjeyDFY1NDHB7ARr1osDyWFBYHCZ48iyAewtdeJL4Ak/a4G83ZIJyzv55Dcce
l1Mie1Ed5+aLcDIuUmoSLwghibYWgOeif/cANTLKUwtLQnChB9epBLMmgICsWZFO
zZK15WEnBfGOrZ3L+BmSaH8SiKPsOLCEg5X5q1sEKOSm0kUtfAGtF7Q+RGkuV/sT
Gh+4i2pW4QqnJD8cBmAKPsDtOiP3BbyM95bJ67nblJHNB5z8WP/bH0hSthQSwtOz
CRfH//J6DkBye6xRzuLgDqVIxY0aSK6W2NAEKZBOfe8XhWvn9yVf64YnVVq4vDxP
fGv2FT0a+l4rgfMx1c8i2xqyh+NHvLPp3E0UHGTVsZdEciA+D7ue6RB7W1bgM+cf
RbwyasfUOIrAVDKhwZQ4Igi33gfDPkx5M5JeiVesmUJDIsPR3HxZLc9tmR3MXI/Y
DEzi2gPVaM83M0sbtigimZWSZsUeNN0leQjuBYT0Gm72Lc69pYWASbKipSkNr1QQ
mVwscVki/uTQ9R9m0b/W6JInYAQmXYXn8uS1oYuaIm0eeOHkCLIG5iBFwd4zqSvM
C7/REYRXMx9DAFu636vD+KW67zcfjD+VsMKaWuWa53hwM2t2M5s=
=JlOk
-----END PGP SIGNATURE-----

--Sr1M8wF/ywytFm6j--