Date: Tue, 29 Apr 2025 12:24:06 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	Andres Freund <andres@anarazel.de>,
	pgsql-hackers@lists.postgresql.org,
	"Imseih (AWS), Sami" <simseih@amazon.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: allow changing autovacuum_max_workers without restarting
Message-ID: <aBELNrA_h4NKtTLi@nathan>
References: <Z3xlNmC3qtwf1lz1@nathan>
 <1359669.1736206603@sss.pgh.pa.us>
 <Z3yVFfKG_RAh8FgP@nathan>
 <1386858.1736220547@sss.pgh.pa.us>
 <Z31jI10tLLd6thfu@nathan>
 <de722583-4ba4-4063-bc41-e20684978116@eisentraut.org>
 <713236.1745846094@sss.pgh.pa.us>
 <aA-TlhU2ZoBBAqc-@nathan>
 <15005c8c-7676-43b7-a440-787b101cfdf5@eisentraut.org>
 <1050120.1745947158@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1050120.1745947158@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/aBELNrA_h4NKtTLi%40nathan>
Precedence: bulk

On Tue, Apr 29, 2025 at 01:19:18PM -0400, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> On 28.04.25 16:41, Nathan Bossart wrote:
>>> However, weren't we considering reverting some of this stuff [0]?  I see
>>> that sawshark is now choosing max_connections = 40 and
>>> autovacuum_worker_slots = 6, and since there are no other apparent related
>>> buildfarm failures, I'm assuming that nobody else is testing the 60
>>> semaphores case anymore.
>>> 
>>> [0] https://postgr.es/m/618497.1742347456%40sss.pgh.pa.us
> 
>> (I don't have any thoughts on this.)
> 
> Andres seemed lukewarm about reverting 38da05346 or 6d0154196, so
> I left it be for the moment.  But I still feel the argument is good
> that "these will do little except confuse future hackers".  Barring
> objection, I'll go revert them.

+1, I almost threatened the same but wasn't totally positive where the
discussion stood.

-- 
nathan