Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 1 May 2025 07:41:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	Magnus Hagander <magnus@hagander.net>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
	"Imseih (AWS), Sami" <simseih@amazon.com>
Subject: Re: Vacuum timing in pg_stat_all_tables
Message-ID: <aBKnEf_yrcTcjIj7@paquier.xyz>
References: <CABUevEz9v1ZNToPyD98JnWDGZgG=SmPZKkSNzU9hXQ-nGTQF0g@mail.gmail.com>
 <Z8cUFTCRFZQIFIYV@nathan>
 <Z8cbKlDUg7zYMv8J@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z9FniRKBthyaC9tn@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="JYfIuFvf1vFFy0l7"
Content-Disposition: inline
In-Reply-To: <Z9FniRKBthyaC9tn@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/aBKnEf_yrcTcjIj7%40paquier.xyz>
Precedence: bulk


--JYfIuFvf1vFFy0l7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Mar 12, 2025 at 10:52:57AM +0000, Bertrand Drouvot wrote:
> Note that it does not add extra explanation to "cost-based delay". If we feel the
> need we could add a link to "<xref linkend="runtime-config-resource-vacuum-cost"/>"
> like it has been done for delay_time in bb8dff9995f.

Sorry for the delay, this has been sitting in my inbox for some time,
and I am catching with some of my backlog.

       <para>
-       Total time this table has been manually vacuumed, in milliseconds
+       Total time this table has been manually vacuumed, in milliseconds. (This
+       includes the time spent sleeping due to cost-based delay.)
       </para></entry>

Hmm, okay, adding this information to these four new fields is fine
here, so I'll apply that on HEAD shortly.  I can see that this matches
with the style used for some of the other fields, like n_tup_upd for the
details regarding HOT.
--
Michael

--JYfIuFvf1vFFy0l7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmgSpxEACgkQnvQgOdby
QH1xfg/+N6Hu0G5yXgt5vqVjR/UBoOZJdAR2qCsbepVu9v+VJxnJPLI7QNCfdL81
is7W5U2VIU/ZOnOOXvnQ94Jk24O7G6U6F36KCh3w+xZm/j1hx9BPbPgJl9i8kqeC
bRzCoEdHhEmFFkeTdRYxLr0wPsQe3VshfSBFfKtFm7jxcCq5fcxs2e7PIqK4wuYV
6WW5xqCy5Xf1qOfsQZuv1yJAytqTNNXtJOd0iAMhuw+3lbxXn3bCVRLol4uRcPJb
1njPQLkBoT49TUxGKaVk4xPyH9s7nfON96FZpbhjIe6P5WijiuxNoK9eVOCAJghM
jMxdqnfxXe/a1NUkqeIQVOWnPhycdF/IibIRQK/iVP9I/4vRlpJWehu90F5LQ1B/
7Yd5E8G3nBFft0iShhAYJECZZRUIq2gxZ7l/FqWPSdhjGfjbTfjbe3VzKa1Aa/Y1
33pT1FEqtKUHjR5jXDpA0ywGzhWBVx5RCdYu/Cp14hcb3/J0Wj/PMKv7x96/hjhr
no0egBRTHwf95aflUz8CdcdtpLObC7KzswnaSPzcfnzNoh8AUdq4YEJULBml2JzG
9QgW/tX+NTYX8xxmdo8+4CK8o1uLV9yIzcNaNwB3qs9bxW78gRYbYba92zhmFx+c
jbOhVNX3Sk7GRg4qqk1YyBQnYst+dJkEsmzgiI0G29v5YJ5K2Zg=
=5v3N
-----END PGP SIGNATURE-----

--JYfIuFvf1vFFy0l7--