Date: Tue, 6 May 2025 17:17:05 -0400
From: Bruce Momjian <bruce@momjian.us>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@lists.postgresql.org>
Subject: Re: PG 18 release notes draft committed
Message-ID: <aBp8UZEO6huMBFRD@momjian.us>
References: <aBQxop9YxQDad8-W@momjian.us>
 <CACJufxH1jo=hv77AK0HUJYBBMuPmr6+JT+8g-yovuJmHUPGOZQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="9HkxjLIU8ELYLv+9"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACJufxH1jo=hv77AK0HUJYBBMuPmr6+JT+8g-yovuJmHUPGOZQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aBp8UZEO6huMBFRD%40momjian.us>
Precedence: bulk


--9HkxjLIU8ELYLv+9
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Tue, May  6, 2025 at 10:13:36PM +0800, jian he wrote:
> Add pg_dump options --with-schema, --with-data, and --with_statistics
> (Jeff Davis) §
> The negative versions of these options already existed.
> 
> Add pg_dump option --sequence-data to dump sequence data that would
> normally be excluded (Nathan Bossart) §
> 
> Add pg_dump, pg_dumpall, and pg_restore options --statistics-only,
> --no-statistics, --no-data, and --no-schema (Corey Huinker, Jeff
> Davis) §
> ````
> 
> in pg17, we only have "--schema-only", "--data-only",
> so description "The negative versions of these options already
> existed." is wrong?
> you can also see the above third item conflict with it.
> 
> ``--with_statistics`` should be ``--with-statistics``.
> 
> 
> 
> Add option --no-policies to pg_dump, pg_dumpall, pg_restore to avoid
> policy specification (Nikolay Samokhvalov) §
> This is useful for migrating to systems with different policies.
> 
> generally, we should say "row level security policy" instead of "policy"?
> I think this sentence ( Add --no-policies option to control row level
> security policy handling
> in dump and restore operations.) in the commit message is good.
> maybe we can change it to
> ( Add --no-policies option to control row level security policy
> handling in pg_dump, pg_dumpall, pg_restore)
> 
> 
> 
> Allow jsonb NULL values to be cast to scalar types as NULL (Tom Lane) §
> Previously such casts generated an error.
> 
> here should be "jsonb null values", since we can not do ``select
> 'NULL'::jsonb;``

All fixed in the attached applied patch.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.

--9HkxjLIU8ELYLv+9
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="master.diff"

diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
index 818c2305a56..3ff9d9830e9 100644
--- a/doc/src/sgml/release-18.sgml
+++ b/doc/src/sgml/release-18.sgml
@@ -1916,7 +1916,7 @@ Author: Tom Lane <tgl@sss.pgh.pa.us>
 
 <listitem>
 <para>
-Allow jsonb NULL values to be cast to scalar types as NULL (Tom Lane)
+Allow jsonb "null" values to be cast to scalar types as NULL (Tom Lane)
 <ulink url="&commit_baseurl;a5579a90a">&sect;</ulink>
 </para>
 
@@ -2596,13 +2596,9 @@ Author: Jeff Davis <jdavis@postgresql.org>
 
 <listitem>
 <para>
-Add pg_dump options --with-schema, --with-data, and --with_statistics (Jeff Davis)
+Add pg_dump options --with-schema, --with-data, and --with-statistics (Jeff Davis)
 <ulink url="&commit_baseurl;bde2fb797">&sect;</ulink>
 </para>
-
-<para>
-The negative versions of these options already existed.
-</para>
 </listitem>
 
 <!--
@@ -2636,7 +2632,7 @@ Author: Tom Lane <tgl@sss.pgh.pa.us>
 
 <listitem>
 <para>
-Add option --no-policies to pg_dump, pg_dumpall, pg_restore to avoid policy specification (Nikolay Samokhvalov)
+Add option --no-policies to disable row level security policy processing in pg_dump, pg_dumpall, pg_restore (Nikolay Samokhvalov)
 <ulink url="&commit_baseurl;cd3c45125">&sect;</ulink>
 </para>
 

--9HkxjLIU8ELYLv+9--