public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: David Rowley <[email protected]>
Cc: Amit Langote <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: PG 18 release notes draft committed
Date: Tue, 6 May 2025 15:44:16 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAApHDvo+BrVTXMBPjNXBTnAovJWN9+-dYc0kN7rSDqdNvpggZQ@mail.gmail.com>
References: <[email protected]>
<CA+HiwqFQWzExQD6cYQsV6Lp4_PkCnGqPwELtEujc_6NTQGJDoA@mail.gmail.com>
<CAApHDvohfoJ0D9eiUuVyHU_kq2Y7A_jAjWVsUt0Fm7Gw1Q=1cQ@mail.gmail.com>
<[email protected]>
<CAApHDvo+BrVTXMBPjNXBTnAovJWN9+-dYc0kN7rSDqdNvpggZQ@mail.gmail.com>
On Tue, May 6, 2025 at 03:14:56PM +1200, David Rowley wrote:
> On Tue, 6 May 2025 at 03:59, Bruce Momjian <[email protected]> wrote:
> >
> > On Mon, May 5, 2025 at 09:42:10PM +1200, David Rowley wrote:
> > > I agree that 88f55bc97 and d69d45a5a should be in their own item.
> > > Likely no need to go into detail about the speed up being about
> > > "EquivalenceClass lookups". I imagine something like "Reduce planner
> > > overheads when planning queries to partitioned and inheritance parent
> > > tables"
> > >
> > > Then for bb3ec16e1, d47cbf474, cbc127917 and 525392d57, something like
> > > "Defer locking of partitions during execution until after partition
> > > elimination". The release notes for 11.0 called it "partition
> > > elimination", so I went with that naming.
> >
> > Okay, I split them up and went with the attached patch.
>
>
> > +Allow partitions to be pruned more efficienty (Ashutosh Bapat, Yuya Watari, David Rowley)
>
> I think you've misunderstood what's been changed here. Unfortunately,
> it's not even true with a bit of eye squinting as these changes have
> nothing to do with partition pruning. I think it would be much more
I think what you are saying is that this has to do with partition
processing of joins, but not the pruning process. I don't think a
non-partition joins are likely to hit 32 EquivalenceClasses.
> informative to state it as I suggested. Also, the spelling of
> "efficiently" needs adjusted.
Fixed. My spell check filter was wrong.
> > +Avoid the locking of pruned partitions during planning (Amit Langote)
>
> At the very least, you'd need to swap "planning" for "execution" as
> the above statement isn't true.
I went with the attached patch.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
Attachments:
[text/x-diff] master.diff (973B, ../[email protected]/2-master.diff)
download | inline diff:
diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
index 9a6e4fb8d0e..92859b5b741 100644
--- a/doc/src/sgml/release-18.sgml
+++ b/doc/src/sgml/release-18.sgml
@@ -397,7 +397,7 @@ Author: David Rowley <[email protected]>
<listitem>
<para>
-Allow partitions to be pruned more efficienty (Ashutosh Bapat, Yuya Watari, David Rowley)
+Improve the efficiency of joins involving partitions (Ashutosh Bapat, Yuya Watari, David Rowley)
<ulink url="&commit_baseurl;88f55bc97">§</ulink>
<ulink url="&commit_baseurl;d69d45a5a">§</ulink>
</para>
@@ -416,7 +416,7 @@ Author: Amit Langote <[email protected]>
<listitem>
<para>
-Avoid the locking of pruned partitions during planning (Amit Langote)
+Avoid the locking of pruned partitions during execution (Amit Langote)
<ulink url="&commit_baseurl;bb3ec16e1">§</ulink>
<ulink url="&commit_baseurl;d47cbf474">§</ulink>
<ulink url="&commit_baseurl;cbc127917">§</ulink>
view thread (147+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: PG 18 release notes draft committed
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox