Date: Wed, 7 May 2025 20:36:08 -0400
From: Bruce Momjian <bruce@momjian.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@lists.postgresql.org>
Subject: Re: PG 18 release notes draft committed
Message-ID: <aBv8eGal7uFr97vK@momjian.us>
References: <aBQxop9YxQDad8-W@momjian.us>
 <CAApHDvqMfTBdfwc0Z-tHXLnBMKJLYEZDApgUzA7x_PUDZsY3GA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="YI807CrXOTYzm13w"
Content-Disposition: inline
In-Reply-To: 
 <CAApHDvqMfTBdfwc0Z-tHXLnBMKJLYEZDApgUzA7x_PUDZsY3GA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aBv8eGal7uFr97vK%40momjian.us>
Precedence: bulk


--YI807CrXOTYzm13w
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, May  8, 2025 at 09:33:49AM +1200, David Rowley wrote:
> On Fri, 2 May 2025 at 14:44, Bruce Momjian <bruce@momjian.us> wrote:
> > You can see the most current HTML-built version here:
> >
> >         https://momjian.us/pgsql_docs/release-18.html
> 
> You might have left it out on purpose as the output isn't likely to be
> read by a machine, but for "Change pg_backend_memory_contexts.level to
> be one-based", d9e03864b applied the same change to
> pg_log_backend_memory_contexts().

Oh, I looked at that commit:

	commit 706cbed3510
	Author: Fujii Masao <fujii@postgresql.org>
	Date:   Mon Apr 21 14:53:25 2025 +0900
	
	    doc: Fix memory context level in pg_log_backend_memory_contexts() example.
	
	    Commit d9e03864b6b changed the memory context level numbers shown by
	    pg_log_backend_memory_contexts() to be 1-based. However, the example in
	    the documentation was not updated and still used 0-based numbering.
	
	    This commit updates the example to match the current 1-based output.
	
	    Author: Fujii Masao <masao.fujii@gmail.com>
	    Reviewed-by: David Rowley <drowleyml@gmail.com>
	    Discussion: https://postgr.es/m/1ad6d388-1b43-400d-bec9-36d52f755f74@oss.nttdata.com

and didn't realize it was an SQL function, though the documentation
mention makes that clear.  Applied patch attached.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.

--YI807CrXOTYzm13w
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="master.diff"

diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
index 59715e71714..5e23688e9b8 100644
--- a/doc/src/sgml/release-18.sgml
+++ b/doc/src/sgml/release-18.sgml
@@ -173,16 +173,19 @@ This is now longer needed since pg_backend_memory_contexts.path was added.
 <!--
 Author: David Rowley <drowley@postgresql.org>
 2024-07-25 [32d3ed816] Add path column to pg_backend_memory_contexts view
+Author: David Rowley <drowley@postgresql.org>
+2025-04-18 [d9e03864b] Make levels 1-based in pg_log_backend_memory_contexts()
 -->
 
 <listitem>
 <para>
-Change pg_backend_memory_contexts.level to be one-based (Melih Mutlu)
+Change pg_backend_memory_contexts.level and pg_log_backend_memory_contexts()() to be one-based (Melih Mutlu, Fujii Masao)
 <ulink url="&commit_baseurl;32d3ed816">&sect;</ulink>
+<ulink url="&commit_baseurl;d9e03864b">&sect;</ulink>
 </para>
 
 <para>
-It was previously zero-based.
+These were previously zero-based.
 </para>
 </listitem>
 

--YI807CrXOTYzm13w--