public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: Richard Guo <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: PG 18 release notes draft committed
Date: Wed, 7 May 2025 16:41:20 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAMbWs4_asKPqTCt0h9pp=zHc9vmPcnczbHeF6Xkxn1LhLapcTQ@mail.gmail.com>
References: <[email protected]>
<CAMbWs4_asKPqTCt0h9pp=zHc9vmPcnczbHeF6Xkxn1LhLapcTQ@mail.gmail.com>
On Wed, May 7, 2025 at 03:03:32PM +0900, Richard Guo wrote:
> On Fri, May 2, 2025 at 11:44 AM Bruce Momjian <[email protected]> wrote:
> >
> > I have committd the first draft of the PG 18 release notes.
>
> > I will continue improving it until beta 1, and until the final release.
> > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-)
>
> Thanks for working on these.
>
> I'm wondering if we should consider mentioning that several
> long-standing issues related to grouping sets have been fixed starting
> from PostgreSQL v18. I understand that we typically don't include bug
> fixes in the release notes, but these particular issues have been
> present since grouping sets were first introduced, and currently they
> still exist in the back branches (yeah, for some reason we do not have
> back-branch fixes; we only fix them in v18 and going forward).
>
> There have been complaints from users about grouping sets giving
> incorrect results in certain cases, which has made them hesitant to
> use PostgreSQL for analytical workloads. Since these issues are fixed
> in v18, it might be worthwhile to point this out — if only to reassure
> users that these issues are no longer a concern going forward.
>
> (FWIW, the related commits are 247dea89f, f5050f795, and cc5d98525).
Agreed, any fix that commonly used to return wrong results should be
mentioned. Applied patch attached.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
Attachments:
[text/x-diff] master.diff (1.0K, ../[email protected]/2-master.diff)
download | inline diff:
diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
index 80cf415bb76..c153c841dc2 100644
--- a/doc/src/sgml/release-18.sgml
+++ b/doc/src/sgml/release-18.sgml
@@ -304,6 +304,12 @@ from the grouping. This was already true for non-deferred primary keys.
<!--
Author: Richard Guo <[email protected]>
2024-10-09 [67a54b9e8] Allow pushdown of HAVING clauses with grouping sets
+Author: Richard Guo <[email protected]>
+2024-09-10 [247dea89f] Introduce an RTE for the grouping step
+Author: Richard Guo <[email protected]>
+2024-09-10 [f5050f795] Mark expressions nullable by grouping sets
+Author: Richard Guo <[email protected]>
+2025-03-13 [cc5d98525] Fix incorrect handling of subquery pullup
-->
<listitem>
@@ -313,7 +319,7 @@ Allow some HAVING clauses on GROUPING SETS to be pushed to WHERE clauses (Richar
</para>
<para>
-This allows earlier row filtering.
+This allows earlier row filtering. This release also fixes some GROUPING SETS queries that used to return incorrect results.
</para>
</listitem>
view thread (147+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: PG 18 release notes draft committed
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox