Date: Thu, 22 May 2025 14:36:03 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Greg Sabino Mullane <htamfids@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>, Robert Haas <robertmhaas@gmail.com>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	Corey Huinker <corey.huinker@gmail.com>,
	Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Michael Paquier <michael@paquier.xyz>,
	Bruce Momjian <bruce@momjian.us>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Magnus Hagander <magnus@hagander.net>,
	Stephen Frost <sfrost@snowman.net>,
	Peter Smith <smithpb2250@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	alvherre@alvh.no-ip.org, jian he <jian.universality@gmail.com>
Subject: Re: Statistics Import and Export
Message-ID: <aC98o_zcR7eiCmPH@nathan>
References: 
 <CAKAnmmKCgnqcd3x4Z+5yXsY7urpDS6D_NZG7pr=DYD=LHt5X4g@mail.gmail.com>
 <CA+Tgmoap_uDKU6K5ch1m=7fiKiEHhbAHWF4EDMhAVG-qdmi=0Q@mail.gmail.com>
 <d7e0869ed38353097293b686ca8d033b36d9c361.camel@j-davis.com>
 <CA+TgmoaFpHyW1ZwCjNxJmvCR0NRMLYCkA=O50BCKLGnC1UcJNg@mail.gmail.com>
 <db541ea000b2371c323c1f5c00ebca2c3a3e28c0.camel@j-davis.com>
 <CA+TgmoYXspGT4dc3jY8B_eJgsT7m=iwqF1i4te3HyG8FdTr1nA@mail.gmail.com>
 <CAKAnmmL35eCAX-XoqwFzauaoJekyM5aNQpTaWDU2GvjeChkyog@mail.gmail.com>
 <CA+TgmoZ9=RnWcCOZiKYYjZs_AW1P4QXCw--h4dOLLHuf1Omung@mail.gmail.com>
 <78dd61cf971436c22c8e7522a4868492b09d1194.camel@j-davis.com>
 <CAKAnmmJ5S48AYbf0g+zjni+-mCHqstrE6kULsFFsv1MhuOL5iA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAKAnmmJ5S48AYbf0g+zjni+-mCHqstrE6kULsFFsv1MhuOL5iA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aC98o_zcR7eiCmPH%40nathan>
Precedence: bulk

On Thu, May 22, 2025 at 03:29:38PM -0400, Greg Sabino Mullane wrote:
> On Thu, May 22, 2025 at 2:52 PM Jeff Davis <pgsql@j-davis.com> wrote:
>>  * The default for pg_restore is --no-statistics. That could cause a minor
>> surprise if the user specifies --with-statistics for pg_dump and
>> not for pg_restore. An argument could be made that "if the stats are
>> there, restore them", and I don't have a strong opinion about this point,
>> but defaulting to --no-statistics seems more consistent with pg_dump.
> 
> Hm...somewhat to my own surprise, I don't like this. If it's in the dump,
> restore it.

+1, I think defaulting to restoring everything in the dump file is much
less surprising than the alternative.

-- 
nathan