Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 28 May 2025 11:43:52 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nisha Moond <nisha.moond412@gmail.com>,
	Euler Taveira <euler@eulerto.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Alexander Lakhin <exclusion@gmail.com>,
	"Jonathan S. Katz" <jkatz@postgresql.org>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
Message-ID: <aDZ4aBbJ_vZTMKac@paquier.xyz>
References: <aA_4S5ZBaI_Qje2s@nathan>
 <910625.1745878759@sss.pgh.pa.us>
 <aBEO7vzq1jw9L_Pv@nathan>
 <1055453.1745949714@sss.pgh.pa.us>
 <aBF1ii89jdzQsVvB@paquier.xyz>
 <aBo7zUx3XpbA2Jo1@nathan>
 <aBqUlxmOf9qvVIhT@paquier.xyz>
 <aBu6xdbOqelnZOCZ@nathan>
 <aBvy3BQL_vaJhnio@paquier.xyz>
 <aDYabIxCPxu4GZxT@nathan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="7bMiXI3b94CkgSlI"
Content-Disposition: inline
In-Reply-To: <aDYabIxCPxu4GZxT@nathan>
Archived-At: 
 <https://www.postgresql.org/message-id/aDZ4aBbJ_vZTMKac%40paquier.xyz>
Precedence: bulk


--7bMiXI3b94CkgSlI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 27, 2025 at 03:02:52PM -0500, Nathan Bossart wrote:
> Here is what I have staged for commit for the others.  I'm hoping to push
> these in the next couple of days.

Thanks for the refreshed versions.  Looks sensible to me overall.

+static inline void
+AssertHasSnapshotForToast(Relation rel)
[...]
+    /*
+     * Commit 16bf24e fixed accesses to pg_replication_origin without a
+     * an active snapshot by removing its TOAST table.  On older branches,
+     * these bugs are left in place.  Its only varlena column is roname (the
+     * replication origin name), so this is only a problem if the name
+     * requires out-of-line storage, which seems unlikely.  In any case,
+     * fixing it doesn't seem worth extra code churn on the back-branches.
+     */
+    if (RelationGetRelid(rel) == ReplicationOriginRelationId)
+        return;

As of the back-branches but not HEAD, this shortcut makes sense.
--
Michael

--7bMiXI3b94CkgSlI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmg2eGgACgkQnvQgOdby
QH3H0g//W6/MdxX8XvKNy0Lov032gT7ID9Bf+maHiXK47/3onD3ZfZAVSiy9soB4
yaDUdWIY2NofFRW8GHKHjom02ztPIXEEyqHTuKD/BvPtqV3Vx2gXr2ajk0yPweaT
VJ9EVYu25xvcybOh+zOq4YapTJJVl/ITCMv3LnEHico8eObiKPDXHpY7Arz7SnvX
2zOC0WHfd4tCBlKCDIo0U9mJu44LdhANJbDli0IMAjufS/1YwybTazTzrtWH7/nO
fuV+dW2Hv+erR5N0XjeSNnWFDbH7x5KWG/O31GoUZlKDXROkdHeS3z13WNuu6TaI
V9E+kNV4rzWmskGN6M7yZ1SBXey+sDUieH1nyxtnFbLEc5oaTUlTX+Ly6ao4rykY
obb5BCFdIAqb2wENcZtJMCa7frEurjrvuGLO4rRYH2jRussOvchNDiv0YKI8NEmG
MPy9+nuKmSjG6dtCsjPcEsd9aCPHVC8HYvde2XfhMCzfy3iSlahfH1+/X7vXoZmi
yHcwgWUCKVG4eC1EqbQPUwtULHUbe8CGn+n3OgMQwOOqm6JwHvwnHqhC4FAU7xkU
gE2pWHfRqAMnlipBqFtC5mbJKzghHvhcJjL5klyzOyoUNKu8NAl0lnbRbH5yGmVk
gM5LcjDSrD6l1WJE+M03PRN3Kt+JTozjn2yIeYAwTG7Z416xGcI=
=tUO6
-----END PGP SIGNATURE-----

--7bMiXI3b94CkgSlI--