Date: Wed, 4 Jun 2025 11:15:29 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Partitioned tables and [un]loggedness
Message-ID: <aEBxIcAiiDVlQvdx@nathan>
References: <ZtcsLnUSuALqEyE-@nathan>
 <Zt6cDnwSvnuLLnak@paquier.xyz>
 <Zt-V90bS4diq4e0Q@paquier.xyz>
 <ZurvG45F3lQHLw4G@nathan>
 <Zur4qqhABOXtZS8h@nathan>
 <Zutc67q6my4AXOt2@paquier.xyz>
 <ZuujwbHFor1zLufJ@paquier.xyz>
 <Zv36cbgluA_oZPYq@paquier.xyz>
 <CAOzEurQZ1a+6d1K8b=+Ww1NFQVwAt9KSCQsBWXYBaPnYCenK3g@mail.gmail.com>
 <CAOzEurRRfPaZn_ZGmoDz2C3+74SAhk+FUZo_9oB1Zg_rQNGkYA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAOzEurRRfPaZn_ZGmoDz2C3+74SAhk+FUZo_9oB1Zg_rQNGkYA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aEBxIcAiiDVlQvdx%40nathan>
Precedence: bulk

On Wed, Jun 04, 2025 at 07:05:20PM +0900, Shinya Kato wrote:
> On Wed, Jun 4, 2025 at 6:55 PM Shinya Kato <shinya11.kato@gmail.com> wrote:
>> Should we consider preventing tab completion for PARTITION BY
>> immediately after CREATE TABLE name (...)? Or is it fine to leave it
>> as is, given that it's syntactically correct?
> 
> Sorry.
> CREATE TABLE name (...) -> CREATE UNLOGGED TABLE name (...)

I see no benefit in recommending things that are guaranteed to error.  In
commit 5c1ce1b, we removed tab completion for CREATE UNLOGGED MATERIALIZED
VIEW even though it is supported by the grammar.  The partitioned table
case sounds like roughly the same situation.

-- 
nathan