Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 5 Jun 2025 09:23:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Shinya Kato <shinya11.kato@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Partitioned tables and [un]loggedness
Message-ID: <aEDjjpritZuv3h2J@paquier.xyz>
References: <Zt6cDnwSvnuLLnak@paquier.xyz>
 <Zt-V90bS4diq4e0Q@paquier.xyz>
 <ZurvG45F3lQHLw4G@nathan>
 <Zur4qqhABOXtZS8h@nathan>
 <Zutc67q6my4AXOt2@paquier.xyz>
 <ZuujwbHFor1zLufJ@paquier.xyz>
 <Zv36cbgluA_oZPYq@paquier.xyz>
 <CAOzEurQZ1a+6d1K8b=+Ww1NFQVwAt9KSCQsBWXYBaPnYCenK3g@mail.gmail.com>
 <CAOzEurRRfPaZn_ZGmoDz2C3+74SAhk+FUZo_9oB1Zg_rQNGkYA@mail.gmail.com>
 <aEBxIcAiiDVlQvdx@nathan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="k8hvF5/+5wglAkUO"
Content-Disposition: inline
In-Reply-To: <aEBxIcAiiDVlQvdx@nathan>
Archived-At: 
 <https://www.postgresql.org/message-id/aEDjjpritZuv3h2J%40paquier.xyz>
Precedence: bulk


--k8hvF5/+5wglAkUO
Content-Type: multipart/mixed; boundary="Gv+kTAVYsyYEBdOh"
Content-Disposition: inline


--Gv+kTAVYsyYEBdOh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 04, 2025 at 11:15:29AM -0500, Nathan Bossart wrote:
> I see no benefit in recommending things that are guaranteed to error.  In
> commit 5c1ce1b, we removed tab completion for CREATE UNLOGGED MATERIALIZED
> VIEW even though it is supported by the grammar.  The partitioned table
> case sounds like roughly the same situation.

Agreed to not suggest the PARTITION BY clause in the tab completion as
it is not supported by the backend for unlogged tables.
tab-complete.in.c has some handling for CREATE UNLOGGED TABLE around
line 3667, so we could just have an extra case for it, like in the
attached patch.  A split already exists for temporary tables to handle
the ON COMMIT clause after the attribute list.

Thoughts?
--
Michael

--Gv+kTAVYsyYEBdOh
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="psql-tab-unlogged.patch"

diff --git a/src/bin/psql/tab-complete.in.c b/src/bin/psql/tab-complete.in.c
index ec65ab79fecb..620830feb9d7 100644
--- a/src/bin/psql/tab-complete.in.c
+++ b/src/bin/psql/tab-complete.in.c
@@ -3664,9 +3664,10 @@ match_previous_words(int pattern_id,
 			 TailMatches("CREATE", "TEMP|TEMPORARY|UNLOGGED", "TABLE", MatchAny, "(*)", "AS"))
 		COMPLETE_WITH("EXECUTE", "SELECT", "TABLE", "VALUES", "WITH");
 	/* Complete CREATE TABLE name (...) with supported options */
-	else if (TailMatches("CREATE", "TABLE", MatchAny, "(*)") ||
-			 TailMatches("CREATE", "UNLOGGED", "TABLE", MatchAny, "(*)"))
+	else if (TailMatches("CREATE", "TABLE", MatchAny, "(*)"))
 		COMPLETE_WITH("AS", "INHERITS (", "PARTITION BY", "USING", "TABLESPACE", "WITH (");
+	else if (TailMatches("CREATE", "UNLOGGED", "TABLE", MatchAny, "(*)"))
+		COMPLETE_WITH("AS", "INHERITS (", "USING", "TABLESPACE", "WITH (");
 	else if (TailMatches("CREATE", "TEMP|TEMPORARY", "TABLE", MatchAny, "(*)"))
 		COMPLETE_WITH("AS", "INHERITS (", "ON COMMIT", "PARTITION BY", "USING",
 					  "TABLESPACE", "WITH (");

--Gv+kTAVYsyYEBdOh--

--k8hvF5/+5wglAkUO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmhA444ACgkQnvQgOdby
QH1KHg//ffeFml2MBmpMxl1nEZR8BSnTIsvhwn2Sz4IM+sVO+Zn3Pp5/c57+4iah
hrXhbpoldoFKs04RIt2Dkqpm5HmKNa4A/mhdpdQ1fp8GHe8L/72AJlDJ4vOQQLdB
iVTzMF/+Amg0ch9bHEcsuNrnVufcfxKwwgN3HrmpdvyiWPsliOJhLUhWz8+eoUPp
gr/o6SfiecX+OSEAl5NiiaQiAt0BT0aCEIT0+QZgRRORixeId8C+F7U6MF3B7SGs
fBKYJMuXAr2/BsW4rX+LKr3wgv7fo5ovqkjSKnzI6gbYbNTozF+6SU3TblFw/dIa
iGB520O2DnfCi0+5pPddo6BXBSl0KueKDdZJo5tGx62e8t99Jk1ujyyRF9rdlis2
Sjt7Px1FPp3ni4M8yejUpVEE1iWQ6qM8x72TIyR60o6HGyuYEvQHV8DH/d01ITr9
BzgrgAhEnIX0dvbbniABHMORLxzjs07H9xugVTUo+ji92WQFMxF3p9BqbQWK2386
a9iHM1BHhFKmQwBdviQpvvoAIGvJQsl5jPotCVb/NQknEaYvA0nW8J7T++bForXU
jVxtA/y3v6V0YJxCkP080B2Yamc0/mUv9Fa9L8j3/8DBL1/14TvQ3/4Px2JJDn9G
f2QRHQuntFP7wJD5EHew3YfinJhLp/rYa1YZOjYxUZIlLoYduh0=
=d8Kr
-----END PGP SIGNATURE-----

--k8hvF5/+5wglAkUO--