Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uP5ed-0001hj-Is for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Jun 2025 20:33:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uP5eb-009DKG-Kr for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Jun 2025 20:33:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uP5eb-009DIL-BZ for pgsql-hackers@lists.postgresql.org; Tue, 10 Jun 2025 20:33:05 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uP5ea-001JH5-0G for pgsql-hackers@postgresql.org; Tue, 10 Jun 2025 20:33:05 +0000 Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-3dddc17e4e4so9767595ab.0 for ; Tue, 10 Jun 2025 13:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749587583; x=1750192383; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yqVzgZyEpW5M+L65xmBovGKkXpWorvdInrQZCSKhHQg=; b=nAG0ATrsJAY/Y9HkeRRaoxL+DG04sscKl+xrNdZgwydmiWpH0Q3OVeVj6YBTmiT4ho 33yh613WbdxQlha9FN/kMDg/CNOPrXFkAI3Dajlc/t+MjR3nNlQiCDLbywDHqyceH3Ab jPWHfQOcl+CrYJSvoghdsdmf2RoSBbR3YTzi2AhJkJ2sRfMUEudg7LHc3ZER28p3HHhK zSNTw2zfnOaHcro22lDc3k1tUtt1da77S7aImwxh3GnS94Vb7XEdo0n8203mUrdFRzA0 AHht0qRxotV2qHYnmLacir0fbZel07NQPSbGZkhqbcMtB63yr5lCfkINlouqsgGVZ0tt TRUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749587583; x=1750192383; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yqVzgZyEpW5M+L65xmBovGKkXpWorvdInrQZCSKhHQg=; b=wWb4l8dYYu/xRUmNb+e3KgmnS49b3J3UXfGPfvb+AzlnWOv9dCBW/u7Qi09DAFdW6s qWEi5xGdPXQSCikGyuh+FU/lWMlyIanuHOdbIK7oKwNZT2KYv+QA1puu0SJRAh7QIH6V RscmWTM6QDglpqJIIgyza8xUwwYIGXh1x3HsQBaK+SBGUwCV9smiPgBbRVeRFHS8M/9t ZDHavhMytUfL/jfjBk/VKYX4j6L+rHtaV7/7kKr7GCYTyCQnFHQA5w57sl0fAdQzlZIH awVQaeAOcw0wwvgBxMinZc4M0CudCWcaJd73WwCOGL1lWtZ7CDcXlzlpWYRaKcxKxxYm Akxw== X-Forwarded-Encrypted: i=1; AJvYcCU/Pbr1D8dEv7hGPga5XmjCRrDdH/xG2Szp6eza4AwVLrzUY2y05HUsTJ6cRZ5L0hCgSTB3VWliO2w1R7lF@postgresql.org X-Gm-Message-State: AOJu0YyUmUOZ/22Bqst53blZx9p8vQ09IFKX2Z/CbncZg0LZ53/Utf8f jWxTe24tnH6ZD9WA+WgDfvyMoFDOBGQeeQaQfr6NeLcvUEM5PD9uKn6P X-Gm-Gg: ASbGnct25h5npnp8tViEA3TJBwtLo2lV+1KJqKLZSNQk7vf7M9sQET70+9IBW8pIF2H raPSEhuQuEY65U4UoNN3wQa8oNOxWDigDdWfs0sPHzqyLhGxPLqnlF1QEdDYaZhlRm3d4LIP+pa JNT+NmWOL90O18JaQI4digYTd0Kp8vBEK65bfo9cYjhzIxPwmMV2zznm3PGJvnWOZ/G4OrBPIgM fY9+g4jtZWMrxHXCXvIJnJXhCJsDTN7FS3OtSGusSEDeNuTPYcbqH4AHMILmmkb/4095vvmhq9V +4csYFGqWQQQzuO1gdN6QEpqHd+CaWbqogE/hDUiK6/OTgV60X+UeDwfcYmgARUe9s6wUj0uLpj UrY3kFHYPkgc3c5/3sYeFBtCdHw+shitp9VntFA7lZm0rXDYbwNmYLSUGW2hKz1pVnkJ/ X-Google-Smtp-Source: AGHT+IH+S6YMkQTFdbzX2/SP4kY7/44fvK6jXqhfs07Qn0sJn1pSghIVKbAplMD/ZhO/7FRJpEQiTw== X-Received: by 2002:a05:6e02:1a45:b0:3dc:7cc1:b731 with SMTP id e9e14a558f8ab-3ddf4cc893cmr1874105ab.0.1749587583057; Tue, 10 Jun 2025 13:33:03 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5012a909ab0sm71307173.21.2025.06.10.13.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 13:33:02 -0700 (PDT) Date: Tue, 10 Jun 2025 15:33:01 -0500 From: Nathan Bossart To: Masahiko Sawada Cc: Yugo Nagata , torikoshia , Pgsql Hackers , rmt@lists.postgresql.org Subject: Re: Improve tab completion for COPY Message-ID: References: <079e7a2c801f252ae8d522b772790ed7@oss.nttdata.com> <20250507222318.421a6b6bfc311f4cdf07ebc0@sraoss.co.jp> <20250508085335.77b8c480e96f032b87c2d8c3@sraoss.co.jp> <0988d0a8c87c37ec8cb8d3643d9dc35a@oss.nttdata.com> <20250603175801.d1fc50eefb178e5ca7312fd1@sraoss.co.jp> <20250610115954.fac87b39e5dfb91e32071b10@sraoss.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sawada wrote: >> > (1) adds tab completion support for the REJECT_LIMIT option, which was >> > introduced in v18 >> > (2) splits the tab completion logic between COPY FROM and COPY TO to >> > reflect their different options. > > [...] > > Given REJECT_LIMIT is a new v18 feature, it seems to me that (1) is an > oversight of this feature, but I also agree that it's not a bug and > doesn't block the release. > > How does the RMT feel about the change (1)? Nathan, would you be OK with that? 0001 sure seems like an oversight in commit 4ac2a9b to me. In any case, I argued that we should fix tab completion for unlogged partitioned tables in v18 [0], and this seems pretty similar. TBH I'd even say that 0002 is fixing a bug and could be back-patched. I've added rmt@ here in case Tomas or Heikki feel differently. [0] https://postgr.es/m/aEH4XYwrlyvjZUvE%40nathan -- nathan