Date: Wed, 18 Jun 2025 10:43:25 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump --with-* options
Message-ID: <aFLenfMRS9jFINxq@nathan>
References: <7cc52488-f876-4ad3-affd-6e4b0ef0cb09@eisentraut.org>
 <aEMLzPQtjRbj2R7X@nathan>
 <CA+TgmoactJEUHeXuxHLKNXHzm6-XrQFigPur-4nHTMFSiSRkiQ@mail.gmail.com>
 <aErpuM6RXSlK1FBW@nathan>
 <7bf0246542713d80f12c738c1d365d1365750c18.camel@j-davis.com>
 <5e398522803da9bf3f9fc33ca43084ec21ab0fcd.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5e398522803da9bf3f9fc33ca43084ec21ab0fcd.camel@j-davis.com>
Archived-At: <https://www.postgresql.org/message-id/aFLenfMRS9jFINxq%40nathan>
Precedence: bulk

On Wed, Jun 18, 2025 at 08:29:16AM -0700, Jeff Davis wrote:
> Actually, I take that back, we can't just remove --no-statistics.
> Remember that statistics currently default to "on" for pg_restore even
> though they default "off" for pg_dump.
> 
> So pg_restore still needs a way to turn stats off.

IIUC the current proposal is to:

* Dump/restore stats by default.
* Keep the --no-statistics, --no-schema, and --no-data options.
* Keep the --statistics-only, --schema-only, and --data-only options.
* Remove the --with-statistics, --with-schema, and --with-data options.

How does that sound?

-- 
nathan