Date: Wed, 18 Jun 2025 12:05:02 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump --with-* options
Message-ID: <aFLxvrh71VWqdL9A@nathan>
References: <7cc52488-f876-4ad3-affd-6e4b0ef0cb09@eisentraut.org>
 <aEMLzPQtjRbj2R7X@nathan>
 <CA+TgmoactJEUHeXuxHLKNXHzm6-XrQFigPur-4nHTMFSiSRkiQ@mail.gmail.com>
 <aErpuM6RXSlK1FBW@nathan>
 <7bf0246542713d80f12c738c1d365d1365750c18.camel@j-davis.com>
 <5e398522803da9bf3f9fc33ca43084ec21ab0fcd.camel@j-davis.com>
 <aFLenfMRS9jFINxq@nathan>
 <58e0969caef94bb4bc83e8a842959dabe29e20bd.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <58e0969caef94bb4bc83e8a842959dabe29e20bd.camel@j-davis.com>
Archived-At: <https://www.postgresql.org/message-id/aFLxvrh71VWqdL9A%40nathan>
Precedence: bulk

On Wed, Jun 18, 2025 at 09:53:01AM -0700, Jeff Davis wrote:
> On Wed, 2025-06-18 at 10:43 -0500, Nathan Bossart wrote:
>> IIUC the current proposal is to:
>> 
>> * Dump/restore stats by default.
> 
> IIUC some people still object to this. Turning stats off by default was
> on the Open Items list. At this point I think we need a pretty strong
> consensus to override that and I'm not sure we have one right now.

Okay, so I see two main choices on the table:

1) Turn on stats by default in pg_dump.  Keep --no-* flags and --*-only
flags, and remove the --with-* flags.

2) Keep stats off by default in pg_dump.  Keep --no-{schema,data} flags and
--*-only flags, remove --no-statistics and --with-{schema,data}, and rename
--with-statistics to --statistics.

Is that an accurate summary?

-- 
nathan