Date: Wed, 18 Jun 2025 22:09:01 +0200
From: Christoph Berg <myon@debian.org>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Andres Freund <andres@anarazel.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: CHECKPOINT unlogged data
Message-ID: <aFMc3SheeQxl0QYb@msg.df7cb.de>
References: <aEMVRbmqqg-aaxAN@msg.df7cb.de>
 <aEMYYEkQb2VeQoBo@nathan>
 <aEmIijETyhj9DsWG@msg.df7cb.de>
 <aEmLzinvZ-W8EPiW@nathan>
 <aEmma1MPm_UgmLP3@msg.df7cb.de>
 <086ab9ad5a2c06eb16f6f4e50a04764ba6fafd1b.camel@cybertec.at>
 <aFAsCyMj-mybBlv3@msg.df7cb.de>
 <aFA10XSdJ9hPGfD1@nathan>
 <aFA7ustE2APIMehs@msg.df7cb.de>
 <aFLmE2zl038I7-F1@nathan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aFLmE2zl038I7-F1@nathan>
Archived-At: 
 <https://www.postgresql.org/message-id/aFMc3SheeQxl0QYb%40msg.df7cb.de>
Precedence: bulk

Re: Nathan Bossart
> I broke this up into several small patches.  Notable changes are as
> follows:
> 
> * Adjusted to the tab completion code to work more like the VACUUM utility
>   options.
> 
> * Introduced a new ExecCheckpoint() function in checkpointer.c and moved
>   the privilege check and options parsing there.

Ack. I was pondering if the code was growing too big there, but didn't
want to change too many things at once.

> * Removed the notes in the docs about when to use the CHECKPOINT command.
>   I'm not opposed to adding something like that (in fact, I think it's a
>   good idea), but IMHO we should bikeshed on that separately, maybe even in
>   a new thread.

I would have thought this already happened here. 

> Thoughts?

Fine with me, thanks!

Christoph