Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTjKK-00921u-RZ for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jun 2025 15:43:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uTjKI-004PcU-SG for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jun 2025 15:43:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTjKI-004PcM-Ir for pgsql-hackers@lists.postgresql.org; Mon, 23 Jun 2025 15:43:19 +0000 Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uTjKH-003fBZ-0s for pgsql-hackers@lists.postgresql.org; Mon, 23 Jun 2025 15:43:18 +0000 Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-86d0c598433so117758139f.3 for ; Mon, 23 Jun 2025 08:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750693395; x=1751298195; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WyoSHAMt2lLZCGAGihc1FT6u6c4peg5KE4lkyNT7cG4=; b=NdBvl4a96QixIFyRlJLuAuIiVOHbQR3LhqV6jVneHw3tE/a3P9SDJg+y2N2fcMS5Mv QakJORrZh7bEwM4B3DXrT8ykf2oZRUfylzcjo5E1A0WfgkS1dXxArmhGL6aoR2LEcxd6 YHWYysEXKAKfxPwjQRns26cPh+I7lY7efZsxAJhsNgKvJMb4aMEuYMSd6egXgXH52aYh HQVrAOjRVJE+mtQBrbFcdVV8t/yRV5dbihSAM5FUzEqrEcceyzukges8zueWQ4vtevVy EQ5FM/rjVa222d0fM8G6IAj8N9fhNO7i8DDSDFviq37KfLOqIvdC7Nz005c3uUU8AI7B S6Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750693395; x=1751298195; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WyoSHAMt2lLZCGAGihc1FT6u6c4peg5KE4lkyNT7cG4=; b=bhiwofHXyAVFPNs+TqJclPvKsnfnU0eNeeX4hW/2+UNcoGRtLnXDQepU8DpOBXDX12 j6BBBliugIS5ETqwJGPU2aEWU9iGN9ElJTWBeJq6Tr21AGAQE8fvUd3AMy8ci3wMqCWT XNpbzMUWZA6kh4IUU40LEMbyiWbpd6/GBQBo/UTi5EKoPHrLeVefqIgOUrhBkiS/a8x9 YTMucGRjv6/ccwisKyd1qDH4HrWCEAD6i3jDP1HVf5qlCNqzO/QECrtdkPfHRMJXE8jc tK8/e3DboiMSHhrSOhhv2tT+NASiFRN4zzkgUznx0MKhfuSS0VvqvejV6Sy3pD05gBm8 wyYQ== X-Forwarded-Encrypted: i=1; AJvYcCWsNQpuMGWxe3PN2E5lZ+U/SPNBGnYMxZUmeMy46wMS6XaqjvYeUUrpzdBfbRU++xN1H5aYz5C37b9A6aW/@lists.postgresql.org X-Gm-Message-State: AOJu0Yy1QCnkkHPmMOcX9w0htyCq2FKyDKpKkthr9XlA10Qr6LCKuwl4 lI65Eb7Vb4j8f9NYtgzRmFclxKI5rC3BLXYdmIvYp0PccfHEIRpWHdeP X-Gm-Gg: ASbGncsYvthgL6LwtpMFrzI9i/6dPRrZd33pazhJswLr0OuOJrF4NKnrc4VY2LuSA0J Ww80nNqKRDmvKfOapxGIuFNuUw3lHNuuTL8+ULSfssAXP+YSGr/FBEC6piTF9XxQlvtIR/Sc9ss LH0f5AgNXAY7P3r2w8rXQh7exUYAfh+rJF5DPAEttRdKchVj1WDgPLMyhZV9ogmeRqfQRbs24uP Coh9AYkCeDhwfIg7EfhG/LZXUjZyRGpT8Vxmd8yPZ/LEo0embGbvyrQUT5zlrVH/EujcW1iQFZT +cMnuT6vTLgz0AnsJ0QEvtE8KFQQOgqEvaw/x0RW53m23hZDLdoXXccH1HMyItQ/kFbfqIEbpVq FJmqJbVcbSBxJXQ8ffvC/NrMF7h2PXmc1LKZgfzuNP642CyuAfjoN X-Google-Smtp-Source: AGHT+IHlTMnu3VqxG0WOEY3HAf2bZFyCItjex4t+rqF08+HofwHAPCgS1qxJTGhVJDVsRwZJH+Bigg== X-Received: by 2002:a05:6602:1548:b0:86c:f3aa:8199 with SMTP id ca18e2360f4ac-8762d1e8999mr1488192339f.11.1750693395347; Mon, 23 Jun 2025 08:43:15 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-8762b60fd86sm254256639f.21.2025.06.23.08.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jun 2025 08:43:14 -0700 (PDT) Date: Mon, 23 Jun 2025 10:43:12 -0500 From: Nathan Bossart To: Tom Lane Cc: John Naylor , Andy Fan , "Devulapalli, Raghuveer" , Jesper Pedersen , Tomas Vondra , "pgsql-hackers@lists.postgresql.org" , "Shankaran, Akash" Subject: Re: Improve CRC32C performance on SSE4.2 Message-ID: References: <87bjqncl24.fsf@163.com> <3350336.1750690281@sss.pgh.pa.us> <3353158.1750691445@sss.pgh.pa.us> <3366258.1750692572@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3366258.1750692572@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Jun 23, 2025 at 11:29:32AM -0400, Tom Lane wrote: > The code still uses _mm512_castsi512_si128, so I think removing it > from the configure snippet might not be bright. Ah, right. I'm not firing on all cylinders this morning, apparently. > I adapted what's > there now to get the attached, which builds successfully on my old > compiler. I still need to check it on a newer compiler. LGTM -- nathan