Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTjaQ-0095tS-Qb for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jun 2025 15:59:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uTjaO-004Y9n-Jf for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jun 2025 15:59:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTjaO-004Y9c-AE for pgsql-hackers@lists.postgresql.org; Mon, 23 Jun 2025 15:59:56 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uTjaM-003ZXe-1F for pgsql-hackers@postgresql.org; Mon, 23 Jun 2025 15:59:55 +0000 Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-3d948ce7d9dso18467225ab.2 for ; Mon, 23 Jun 2025 08:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750694393; x=1751299193; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XhilaX22vbZU2374HV6ECuSR7XFLFGUpGBDrTarbg1I=; b=b3VSCKdCWT+6VElqybZtmJ1br63W5NxUP330Z/dSHAXIwOkuAVM/4VTK5not0f83GR 3CXj5DehAwZp/2f+t2PxcokTFiMD3Dh+u9iDLJu7dW6VUfENYm6AJ051k4cMpQRBdilU vROvtan3cbEbMhhwez7oNxspyV1CH2Fm6aJzFnvgPZsgYdLIovRSLz5UpP0Rk4kltC/Q uRLOnDjtfbGMcO8S+Q+tEuig7FfSTwsG53xRsGGARtYP1dqeji0WKLQKngNTcNZqG7jr /HnwXz8SP5aeYEmXapw590sGgaidudbNI6xQsuubtLtCPb0IZXMkBTUS8JjcEznCyTtG 1O2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750694393; x=1751299193; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XhilaX22vbZU2374HV6ECuSR7XFLFGUpGBDrTarbg1I=; b=hpIdFPBzZ/Uk9YmXph+L4o/TxigXo9R4N4qa+mTs0WRugettzh7ItcydymE9PDr4ik RYgmBEH2c8yjYfriysJOdNiZeKQ+ib6z1X7/Zx6A+vrm3ObHM4EmIx5VMIVKv9xqu0SF QWYX2uIPpMm/gkgfLuAduEFrtSAA8OXiatP0ugnEJ1eU7eJL8MTCBYa9z7oXeUxcAjc3 WuX7zeOUSh5cf32ByWZxPhpbHYt0okcoA0KEU+B9/S+jfkM4wjCkKhS6JT/Hs878r6kX 1Sn70Bo0+MvJtXMBDInYzdoGTP91HUpMylcbUhBy2VT079eJgnBxBwNej4kzRn7k0wRt D5ag== X-Forwarded-Encrypted: i=1; AJvYcCUyI95EEVWZpS9BRO8dDIP1og3jaXO8M0qCKp4vXqnShitn4m8reWFxLVr7IOcXM+Mlku1BVHuyyMfshkmG@postgresql.org X-Gm-Message-State: AOJu0YyBt3vHg4ow9AcpTjmnKVwucGThQ9y8n2QAjusVw5f/n2+9QHVD kIWJZzcEPxRzNNqgtPdjTotrnS2/KrRTWJ4ayXfKavzFIvj/cf5DmUZCKhUoRg== X-Gm-Gg: ASbGncsE7s0LqJT6+ctEpCFuNZkxqe88QCndpfYo96Nrz2gXCFLPuBAsgJ/CJa/XQbK 6YgLAwleK0bilveXr9NMbym3X6YCpWpUksaEMdaLY25l5TzS2kB3MXKTmltmZmGMNmFd5TzQwLz fHSx1eBUSamabqhLJZd8ABE1g/sLqCyoN/ZVtqw/+RZZCtugb8Ph4cdeA+eWI1WFmtUawxYk40j j/qEkQzpQiebSl/UxfFzf7dxBpHw+E3ZvMQUyXe9N3eQOSKe5vkehvnJaarnF3Rdf3Wv++CH/Jz y2WwLky8qwN26DIfXK0y9CRMAw0Y1HY1FSsRUVDaVzt7edKAAlS9VTOJpq4yyjJH7mIBRuItQIs 44dNY0E2zi7CtkmBlIzg58qkAA4Ta24E4rXvqFAqwnMTy8cDRPQKCpq7x7e4sfzw= X-Google-Smtp-Source: AGHT+IHUJHgZFXPnmOtQBymvgAYpC8YznuNUQN5d/T1QZ+F6ks3FyrcDhGx5zIvf6h9NEfVPH5LIwA== X-Received: by 2002:a05:6e02:3499:b0:3de:119f:5261 with SMTP id e9e14a558f8ab-3de38c1c019mr192946695ab.3.1750694393449; Mon, 23 Jun 2025 08:59:53 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5019e0ac9bdsm1895786173.125.2025.06.23.08.59.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jun 2025 08:59:53 -0700 (PDT) Date: Mon, 23 Jun 2025 10:59:51 -0500 From: Nathan Bossart To: shihao zhong Cc: Michael Paquier , pgsql-hackers@postgresql.org Subject: Re: problems with toast.* reloptions Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Jun 21, 2025 at 11:45:25PM -0400, shihao zhong wrote: > 2) When updating a table's relopt, also update the relopt of its > associated TOAST table if it's not already set. Similarly, when > creating a new TOAST table, it would inherit the parent's relopt. > > Option 2 seems more reasonable to me, as it avoids requiring customers > to manually resolve these options, when they have different settings > for the parent and TOAST tables." I like this one, but since it won't fix existing clusters, it might only be workable for v19. -- nathan