Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTikB-008qbr-3F for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jun 2025 15:05:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uTik8-003wYy-Q8 for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jun 2025 15:05:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTik8-003wYq-Gv for pgsql-hackers@lists.postgresql.org; Mon, 23 Jun 2025 15:05:57 +0000 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uTik6-003ern-1o for pgsql-hackers@lists.postgresql.org; Mon, 23 Jun 2025 15:05:56 +0000 Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-875dd57d63bso141298639f.0 for ; Mon, 23 Jun 2025 08:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750691152; x=1751295952; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YPoCAHu/kgNuApT8XCtDs/JM6THf5I2w7d/VqZ0bZKQ=; b=EA6wwFE2hIeF77BpYsIEO9sWcx3q1dV+l91SFSeCYUl74sHQ4F+XOSlCa230yEfz8u CqK6GF4xYl7MldbcZi16weQASRM7bBbrqsxyKrIVtwLNpoeW1KpRHvc3emq+TkdZHfM3 oizdWWHp5RLOrim8rv71JtgnAXFXEOoLwlifaLcT0Qk1eAomdPMAxSGH3e7EM8j5FEhU n1g3rs9cfkUiWSumXxIrxoEs3KAA5KHhzFev5cDQCAPYwCvFwD7ZnzDmB70Yvxty8mZS D2B7SH3scUNH2af3LqgO14RZ6WZTtQlLsEPBEXW9b3kDes+W1wNj6OXoMwraHffZrZ/s oq4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750691152; x=1751295952; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YPoCAHu/kgNuApT8XCtDs/JM6THf5I2w7d/VqZ0bZKQ=; b=PXp0mcJtjRaT1iRqhgp7Zh8RWS/NXq1W2dKLK7EABSAbI6EZIRoXWam7PVTyML9fHU 9SqYNA9p2RAaqdkAmCgLbNR6R0QG1tSyOq8cBQl5zfJjFAfpcZtcs5MD/ryfn6NxTmeW vYE4SE4AkQSumZGtC+NNI9nZDpDs+TS0FeH2Q/D699JKMXrMLJtLL+8yFocXgEPlHfCD CVe83+BR9tAlzlirZTiv1Qash8Q1hUpYskuGEiKXwWuV3ir/buGeLyBZCtHSHL7xf+XK 4/rxUbG8JHko31TfI8x7m1lvy6Vhf/7lxw0WN6F/Oth6kqAO50b2uz26s3bZENWA4e9w QZPw== X-Forwarded-Encrypted: i=1; AJvYcCWRyFk1YYJaOJTASAuC5BlbLLSL/u7qJY0TbAD0S9nOogSSt2WFQrLeztowIiXsXYYyqFpi4zVPbUa0FXRU@lists.postgresql.org X-Gm-Message-State: AOJu0YwjRmtkirO7OjWILMr4uxrv6YDCJG88IdvYAZhDmzsIbDGp9yDP hAe2ybAzqYlQADBwflhTYEblcAg2qNr06/KBGE4Dj7aJnLxmbVFy/PXu X-Gm-Gg: ASbGncuzxavj2/rXjydmjda+3f8Y+i1+Fv4XBF7eT+clechUMmbAy5ElvbV54wh6Iga rYossurIElXk/9aroPLPbwt3VksUwXMgrtsWBebxulG/asgcTxDVkMOoNIuFTCrWaI+8H2UJmVH acC6ns0usDXXKRXFtilAFR6TLOvdX9jLCXNwEyLxATK5gtbjtw2SB6lYURpT2T8vmnuipp5lmyt IindlTFM2gnLYBc4UKx9kkEsNyNj21Ezl8q/hQ7lnzOTR/dbP1L9BQp2P0MP6rBp8Bn3mJwRbDH QU3Q9W4E97VmKXi20fq1zVLvDBOUTevaq00W+dptZ8x5EQZYnn+r5xmkgfsZiFdGiE6Yn+6Of1s RuZRlp2ED8UQNRzHe0Oqnwg9nieAZwCOT0Faj1hDL+4MoBcsgUQuU X-Google-Smtp-Source: AGHT+IGfGRcyOOkgvLRJTi+Q+S/FyUBmhgvCbxrnxJMVqwT+fY9ca9Chc82d8MCpERnJhQgQM859tA== X-Received: by 2002:a05:6602:6d0c:b0:867:8bb:4d8 with SMTP id ca18e2360f4ac-8762e0f056bmr1337746939f.0.1750691152225; Mon, 23 Jun 2025 08:05:52 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-8762b6a0613sm247997339f.23.2025.06.23.08.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jun 2025 08:05:51 -0700 (PDT) Date: Mon, 23 Jun 2025 10:05:49 -0500 From: Nathan Bossart To: Tom Lane Cc: John Naylor , Andy Fan , "Devulapalli, Raghuveer" , Jesper Pedersen , Tomas Vondra , "pgsql-hackers@lists.postgresql.org" , "Shankaran, Akash" Subject: Re: Improve CRC32C performance on SSE4.2 Message-ID: References: <029f0848-8bc2-4d99-aebd-345949f97622@gmail.com> <87frg1dc3k.fsf@163.com> <87bjqncl24.fsf@163.com> <3350336.1750690281@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3350336.1750690281@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Jun 23, 2025 at 10:51:21AM -0400, Tom Lane wrote: > This has broken the build completely on my RHEL8 x86_64 box, > with gcc 8.5.0: > > $ ./configure ... > $ make -s > pg_crc32c_sse42.c: In function 'pg_comp_crc32c_avx512': > pg_crc32c_sse42.c:126:25: warning: implicit declaration of function '_mm512_zextsi128_si512'; did you mean '_mm512_castsi128_si512'? [-Wimplicit-function-declaration] > x0 = _mm512_xor_si512(_mm512_zextsi128_si512(_mm_cvtsi32_si128(crc0)), x0); > ^~~~~~~~~~~~~~~~~~~~~~ > _mm512_castsi128_si512 It looks like thse weren't added until GCC 10 [0]. > I see similar symptoms on buildfarm animal conchuela, which > is DragonFly BSD of some vintage or other. Not sure why > more animals aren't complaining. Anyway, it seems that the > configure probe to see if this facility is available had > better be adjusted to match the new code. Unfortunately, this will probably require more than replacing _mm512_castsi512_si128 with _mm512_zextsi512_si128 because the latter doesn't exist. [0] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83250 -- nathan