Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 2 Jul 2025 09:46:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andy Fan <zhihuifan1213@163.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: A assert failure when initdb with track_commit_timestamp=on
Message-ID: <aGSBcvlXY9FDkcsr@paquier.xyz>
References: <87plejmnpy.fsf@163.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="abJrl1HWvLiwLYst"
Content-Disposition: inline
In-Reply-To: <87plejmnpy.fsf@163.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aGSBcvlXY9FDkcsr%40paquier.xyz>
Precedence: bulk


--abJrl1HWvLiwLYst
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 02, 2025 at 12:38:01AM +0000, Andy Fan wrote:
> However this is not true in BootstrapMode, this failure is masked by
> default because TransactionTreeSetCommitTsData returns fast when
> track_commit_timestamp is off.

Agreed that there is no point in registering a commit timestamp in
the cases of a frozen and bootstrap XIDs.  I would recommend to keep
the assertion in TransactionIdSetCommitTs(), though, that still looks
useful to me for the many callers of this routine, at least as a
sanity check.

I did not check, but usually we apply filters based on
IsBootstrapProcessingMode() for code paths that we do not want to
reach while in bootstrap mode.  Could the same be done here?
--
Michael

--abJrl1HWvLiwLYst
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmhkgXIACgkQnvQgOdby
QH2YuQ//fqauKO0gDfVIBn5M83aG8l37gYPonO3pVgtoCnOORYvC0uTQaIjEcGco
tlIRkCQ0BeBT8Ph8vFpoVraU3navtRx1zF4HBGK9LBT4aWapSc2f2P+Ve3gSjJlT
RWTB7MEERraStu6PqjCBoqfQ9h+ZayyeMT3YFj+QKbhQ8iTAS+Ubg18bfEPc4/3t
ws/NQQZLtnKmEVbum+5LkyHOkF92nJ/hAg0CXAqBROczvigIGhadyn3XvieuTxxg
fPynW2/CW7a4CNd65Lk3VqkI60UrcmY69OGlr8GfzwowqMVvFMYzbfOZh3UDITOF
fRAyDMOWqgOznMq8oOjZfqutDfqfnig33XYzE9Xb7RSmG9JtLSHGTgAaiiK5nj7L
NkYaCQT94oxdWyvNFKosl9etg/zOmQveWVgUI6TLR45pGbm9H4ZeqCN9Z6iFDZBT
6pOBI8DujrSF9AIX3d2P1psO6r2vY/fHyroT/37hWlOU+UdJGVpIUzmiChPU6FpP
2m22x0xAnoTRIonPccDWfht7gkjTSvGp25TkeaebOS3p/w47DGKeuLDX1AOZ0i4O
BgaFj6LEpujQTDkuLTjvYC9adtVbDc4MCSluSnVZLaeXREG+ortcNPwUuse5F7rb
cTROnOM99u2gVbI5UkQjbWyR/T5bnlH6a/qBnyR6LQ1FMtUfF5Y=
=KJe7
-----END PGP SIGNATURE-----

--abJrl1HWvLiwLYst--