Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 3 Jul 2025 08:14:32 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Jeff Davis <pgsql@j-davis.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>,
	"Maksim.Melnikov" <m.melnikov@postgrespro.ru>
Subject: Re: Persist injection points across server restarts
Message-ID: <aGW9WHJj_vNclP1s@paquier.xyz>
References: <aBG2rPwl3GE7m1-Q@paquier.xyz>
 <7eed8fc7526343dc3827e89b3cea9e6a5fee9470.camel@j-davis.com>
 <aD52UvdcePErVE8F@paquier.xyz>
 <fifaey5hwslne4mf4j6mkecdruyzdyb72yjc36waral6w7dwpq@45ffveomfqk7>
 <aD-QDOegY0yrw1AW@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/61PuobjhrADvvkK"
Content-Disposition: inline
In-Reply-To: <aD-QDOegY0yrw1AW@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/aGW9WHJj_vNclP1s%40paquier.xyz>
Precedence: bulk


--/61PuobjhrADvvkK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 04, 2025 at 09:15:08AM +0900, Michael Paquier wrote:
> On Tue, Jun 03, 2025 at 03:34:16PM -0400, Andres Freund wrote:
>> I'm somewhat doubtful this is is the right direction. Tests that require
>> injection points before consistency also can't wait for injection points=
 using
>> the SQL interface or such, so most of the stuff has to be written in C
>> anyway. And if so, you also can attach to injection points in the releva=
nt
>> shared_preload_libraries entry.
>=20
> Hmm.  I'm wondering about an alternate approach here: a postmaster GUC
> in injection_points that can take in input a list of
> name/library/function where the module would load them when
> initializing.  That's a bit artistic, perhaps, still it would work
> without having to worry about the flush and reload steps.

[A couple of weeks later]

I am still not sure what's the right course of action here, so I'd
agree to just reject the patch for now, but keep it in mind once we
have more cases where this could be useful.  The case I've found is
perhaps not enough.  Updating the CF app to reflect on this feedback
now, thanks all for the input.
--
Michael

--/61PuobjhrADvvkK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmhlvVgACgkQnvQgOdby
QH31vQ//bLf4LQr4LiCrMD6Jcetwk6ATS5f1C7u40xi9a6tvIf3KOt0Nvr1RaFxe
He6erHrPjj8a2+tok1msDBAMyPW7h1rJDFauTe6WEsueNk4LhkIpdWKdHAqeRb+T
+fjVW+R1ujKP1k3OQQwyslldh41t5r0vDZfUwONUl73VuULAI+wwB7zb9NKP5TQP
ogwIZlsBckN6fPCFJDn1NCKPgRnu5JC7c7JP9jb/n3/xo/IGVjEva90Yk+l/weUL
wH78Wtz21vBuI8+s2D882BoSm/vyT9BWNe/zH7FdxBHBnmcGpLpqe+1rNofOG/Ue
PW8+ejSr1Lp8w9hoceHr7KrkFLxJyEBvPNz+CySXZrTQzYk/AwW93fB0xF9f721G
F+6GeeuOCj7AUOC2fRsSlO7672wn6dI+I/8XGhOxZItPwXpS4Evyx2geLTFu+3st
0BxWfs6LO26rKM3/qAaTISwjZ+yOZGZZluOplKTfxdIjUrmCOUSChjKoCC/7KLI/
MR4J+6MooBGwHh7/0JUwZsrJkreE+4oKVihEVkYJ5BZCzoRmKNnq+tLk1wYBWcEo
SHaonF76YPMpWOPTxaP9NuXwuxjAhCVS0YhbObrNe7fbDPc06K8H3NJ/RFg1KLg6
UWA5NaUYVTb1hj/p6s+nm62yX/7NgBjsVbDTLwqKPUoZB7tTfGs=
=1V6W
-----END PGP SIGNATURE-----

--/61PuobjhrADvvkK--