Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 22 Jul 2025 08:07:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Andrei Lepikhov <lepihov@gmail.com>,
	Greg Sabino Mullane <htamfids@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Nikolay Samokhvalov <nik@postgres.ai>,
	Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Subject: Re: track generic and custom plans in pg_stat_statements
Message-ID: <aH7IPp_Hku02xHP2@paquier.xyz>
References: 
 <CAA5RZ0v4Lqc3KOzFCOJd0hjBpF10W=-E6xn0z_HizZY9uxPR0w@mail.gmail.com>
 <CAA5RZ0vK_fah+ZS00hdg9uH2J_zBgV75x6ojYrc6+OJudnbKtQ@mail.gmail.com>
 <5f775987-8a93-452d-bb3f-a1de53836406@gmail.com>
 <CAA5RZ0uxcVu9MPXQc6qJ5mtYhH=_7b7jjaDnvg6Sft8jJ1NbXw@mail.gmail.com>
 <56d31e81-79d8-40bd-b957-0d6dc7c46589@gmail.com>
 <CAA5RZ0tdc4HeHdFRvVPWBdXP1JwCSjPPgiQyFk8fwhv=4fKmjw@mail.gmail.com>
 <2f2bde53-972d-402c-9da3-c5467cca00bf@gmail.com>
 <CAA5RZ0tfr50T1xYET=1Ei=NkbmS3e7MFhMJTrnoLi2oO7n2JsQ@mail.gmail.com>
 <064b9efd-92c9-4670-95f4-d911d4c7ddeb@gmail.com>
 <CAA5RZ0ss-jmqeze0G8anztzLRJuMEgz9y3gTd-rgTc2Ejtwzvg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="hQn4BZy8HSP7fWYm"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0ss-jmqeze0G8anztzLRJuMEgz9y3gTd-rgTc2Ejtwzvg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aH7IPp_Hku02xHP2%40paquier.xyz>
Precedence: bulk


--hQn4BZy8HSP7fWYm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 21, 2025 at 04:47:31PM -0500, Sami Imseih wrote:
> Last week I published a v11 that adds a field to QueryDesc, but as I thou=
ght
> about this more, how about we just add 2 bool fields in QueryDesc->estate
> ( es_cached_plan and es_is_generic_plan ), a field in CachedPlan (
> is_generic_plan )
> and after ExecutorStart, and if we have a cplan, we set the
> appropriate plan cache
> mode value. I think it's better to confine these new fields in Estate
> rather than
> at a higher level like QueryDesc. See v12.

Yes, I think that this is a much better idea to isolate the whole
concept and let pgss grab these values.  We have lived with such
additions for monitoring in EState a few times already, see for=20
example de3a2ea3b264 and 1d477a907e63 that are tainted with my
fingerprints.
--
Michael

--hQn4BZy8HSP7fWYm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmh+yD4ACgkQnvQgOdby
QH3YXxAAnmKmXxtt+XzD1hOI0GPQePPaFkgiFKiiSrDq3wey0OUVRgs7pA+4IjIF
/CuHWAyt9bH9ZO0dHJNDdN+TO7SqC7/RjqbRq1hEs5FGRIg6KZT783nczN/UKFOk
wL6EBpcVDq80whz4eSeqz+UorUqiBtGroPEqfr1uIcpPw8yn8kNUxuQqMdoQJRvP
JhPOfj9skFtjxebWZcmKXedouZ5UP+gkIKhdbP4+aOS5XlnIZV4If7VjZn/mcOY1
WXTelEe1a87bkJElV3ZT+BcYreNdkW7+aaEYndvk2pJCEvC8Vipc9b3IcBDb+rmd
f3cn+9/ga8vV53eTMJYah8YTfJ/oEc7U6kTaCnqn9+MbTT6gEZ6zv+xoFae+fULo
o2TE3ROjN68/jMqepYCM/i3tsIBhAersnK2uFJaskn08A9/AV3AQCKaGZ75ylPnn
iRZxYir1lsy0TXgklljKDjtT3A9c1BwM41nQazqNk3hDeY/Almr7wVSEMUZOIzuq
ROcWRAeMgOFRMfoU/BnflXDlzXsBCymDIMKL1ub0yWlnkANrWwSIG6uvnqwThjX8
FbBnb8HoOYwk+ifI6+vuQ1GX7tGOC9I89sps89GGeWUjFHaTtsO0nWlKVhCy4xjy
g4d8hGYDhuympUSHbWTtV7IDQ8XOoqY3+bs/Xs8khF4tUWaZYhw=
=SqPX
-----END PGP SIGNATURE-----

--hQn4BZy8HSP7fWYm--