Date: Thu, 10 Jul 2025 16:42:23 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Nitin Motiani <nitinmotiani@google.com>
Cc: Hannu Krosing <hannuk@google.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Horribly slow pg_upgrade performance with many Large Objects
Message-ID: <aHAzv9pgJh2Wa3M1@nathan>
References: <Z_VTucTiS01p-d6z@nathan>
 <4050387.1744132029@sss.pgh.pa.us>
 <aBkQLSkx1zUJ-LwJ@nathan>
 <aBtzZ4PyccUVCcyA@nathan>
 <CAMT0RQTXiqH7zdQEVSVd2L7_Cw4wQ1eHOD8hfZ+0vecMXJWc-w@mail.gmail.com>
 <aG2ISJC__3lQwRqY@nathan>
 <CAMT0RQStPtHfKwowd88Q0tynX0x=uJSKn=ihP8syhDJ6cH3DHQ@mail.gmail.com>
 <aG6srPib60NzJBeg@nathan>
 <CAMT0RQRT3KkwoQkx=YBdd_o9SqXxOt16fqQsscH_n+40Z57N7w@mail.gmail.com>
 <CAH5HC942o6j1qyVysiBtO+Vpb=XOBPbf3rKqsOLtpDpp0SzjkA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="wDo6IHo3pIZ/EZgg"
Content-Disposition: inline
In-Reply-To: 
 <CAH5HC942o6j1qyVysiBtO+Vpb=XOBPbf3rKqsOLtpDpp0SzjkA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aHAzv9pgJh2Wa3M1%40nathan>
Precedence: bulk


--wDo6IHo3pIZ/EZgg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 10, 2025 at 06:05:26PM +0530, Nitin Motiani wrote:
> -		 * pg_largeobject_metadata, after the dump is restored.
> +		 * pg_largeobject_metadata, after the dump is restored.  In versions
> +		 * before v12, this is done via proper large object commands.  In
> +		 * newer versions, we dump the content of pg_largeobject_metadata and
> +		 * any associated pg_shdepend rows, which is faster to restore.
>  		 */
> 
> Should the comment provide further detail on why this is only being done
> for v12 and above?

Yes.  I've fixed this in v3.

-- 
nathan

--wDo6IHo3pIZ/EZgg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v3-0001-pg_upgrade-Use-COPY-for-large-object-metadata.patch