Date: Fri, 11 Jul 2025 09:57:02 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
	Christoph Berg <myon@debian.org>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	Andres Freund <andres@anarazel.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: CHECKPOINT unlogged data
Message-ID: <aHEmPoZt6hHbzEwY@nathan>
References: <aFA7ustE2APIMehs@msg.df7cb.de>
 <aFLmE2zl038I7-F1@nathan>
 <aFMc3SheeQxl0QYb@msg.df7cb.de>
 <aG7Cbf9dju1kkzGE@nathan>
 <6c4a6fe7-a530-4f21-aa38-9e3adbcc5410@oss.nttdata.com>
 <CAFiTN-sTO1qscO98DrAoBW9BBs4skWp39McnFcSZi3D25t6sPg@mail.gmail.com>
 <CAFiTN-staR+Thi8=0cFebN=pGSFUK8CEiS9qWHWGReSdkCPkgQ@mail.gmail.com>
 <CAFiTN-tfAqM538W40Z0Y22NTODDi7ThBuUW+o8GD1vHOMLHC+g@mail.gmail.com>
 <aG_kOm3bkKVKjmhI@nathan>
 <CAFiTN-vxo=8Obphd-CfJ_kkTPKo8Gze=Vx9HigSX5vwhRJGjqQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAFiTN-vxo=8Obphd-CfJ_kkTPKo8Gze=Vx9HigSX5vwhRJGjqQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aHEmPoZt6hHbzEwY%40nathan>
Precedence: bulk

On Fri, Jul 11, 2025 at 08:43:05AM +0530, Dilip Kumar wrote:
> Thanks now, looks good to me.

Thanks for reviewing.

> Additionally IMHO it would be good to add tests with FLUSH_UNLOGGED TRUE
> and FLUSH_UNLOGGED FALSE as well, I have added a simple 2 test for the
> same in attached file.

I'll add something like this before committing.  In the future, please do
not post small add-on patches like this because it confuses cfbot.  If you
must, I think appending an unknown extension like ".nocfbot" to the file
name is sufficient to prevent cfbot from picking it up.

-- 
nathan