Date: Mon, 14 Jul 2025 12:51:20 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nitin Motiani <nitinmotiani@google.com>,
	Hannu Krosing <hannuk@google.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Horribly slow pg_upgrade performance with many Large Objects
Message-ID: <aHVDmAqcwanTAGZa@nathan>
References: 
 <CAMT0RQStPtHfKwowd88Q0tynX0x=uJSKn=ihP8syhDJ6cH3DHQ@mail.gmail.com>
 <aG6srPib60NzJBeg@nathan>
 <CAMT0RQRT3KkwoQkx=YBdd_o9SqXxOt16fqQsscH_n+40Z57N7w@mail.gmail.com>
 <CAH5HC942o6j1qyVysiBtO+Vpb=XOBPbf3rKqsOLtpDpp0SzjkA@mail.gmail.com>
 <aHAzv9pgJh2Wa3M1@nathan>
 <CAH5HC94tYpgCnoPRYbCGQU0eCM8D7X+aEmB0GZrhjR16JEe5_A@mail.gmail.com>
 <aHEk_JEoNhIpuHd-@nathan>
 <CAH5HC96=3NjeYA5vuj8CyMmiFhU27jgvQ9WgXbUDccrE7xvwYw@mail.gmail.com>
 <aHUvLi_sdfBrxzYh@nathan>
 <700576.1752514083@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="UqDA4lFk7M2lL48P"
Content-Disposition: inline
In-Reply-To: <700576.1752514083@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/aHVDmAqcwanTAGZa%40nathan>
Precedence: bulk


--UqDA4lFk7M2lL48P
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jul 14, 2025 at 01:28:03PM -0400, Tom Lane wrote:
> Is it intentional that this does
> 
> +#include "catalog/pg_largeobject_metadata.h"
> +#include "catalog/pg_shdepend.h"
> 
> rather than including the corresponding *_d.h headers?

Nope, that was an oversight.

-- 
nathan

--UqDA4lFk7M2lL48P
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v5-0001-pg_upgrade-Use-COPY-for-large-object-metadata.patch