Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ufJVO-005Nm4-LF for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Jul 2025 14:34:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ufJVN-001RrA-G5 for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Jul 2025 14:34:37 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ufJVN-001Rr1-2P for pgsql-hackers@lists.postgresql.org; Fri, 25 Jul 2025 14:34:37 +0000 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1ufJVL-000jTk-1k for pgsql-hackers@lists.postgresql.org; Fri, 25 Jul 2025 14:34:36 +0000 Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-3e2c521efddso20916685ab.3 for ; Fri, 25 Jul 2025 07:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753454074; x=1754058874; darn=lists.postgresql.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KYvw14oHJvMq8R47dudtHXchjTwa5yc+B1PesTlQ/dQ=; b=M62m2US1THRIojal34JJ8Vu3ojlog3AE4Loy84RBqEpJ2tMlzgHnxs2u+SzCy6zDBX UPPRW041ONnrOy2B0yjM/0DZwM6uCs0FZ1awbf6id37gig29cl9GIMi0ktUQ57yQrEXU d6ztswuEa+f4bJf5MjN5a1yeCkTPbU4DZK/Z9QlBqS1V6z7gOimuxyb/HqJN0QhkmTyn SjToJoIZIDH8zfq3L1h5Jht+t1cprbSEwlAb8iTvKG7n+4YcD0HCxGQuSFqGoQUb4o9z X5bhBxOFhAKuunD9p1a4HiMXPzfGCxcG/dUz/i5tzhaZGsZ1ZDm24mLtY9mZvGBkBqTF qrwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753454074; x=1754058874; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KYvw14oHJvMq8R47dudtHXchjTwa5yc+B1PesTlQ/dQ=; b=wd7sboGRhx6c8Fx/AWTZfcY0R6CcFtNHQYlHwPeU6UfCsxUhT532GRQqDZYRLtzBVK CHLBtwvbd0hVAzv79/hnhL+GgpitdUqkQtRYu/oIFBy0qP58NQID6rBUk0XMv+D3KMQD e+s8IBX5Y8smPVEEbYCyGr1uEUTu/LsCgFNxTcZyE/aXtwRj0d8Wlvl6zihQCLQfz+2F nSXLn49a6iwsW0OkgE5wHRP9XVCPuOaAJs0mf4TiTZshGbWdfqlMhEU+VSP4lItvwJ5L GIwP5FcM1OHArFdMVeWMaC3YO0rnmCzQW1yp8s8bUeZmSO3upskuUxDsRwKzpwjtiAbi FE2A== X-Forwarded-Encrypted: i=1; AJvYcCXTmMDRE6JBx+vpr98bmvnElGOio2Z8q48PEthgy7a3gUArZxeda+o5fofHmZNN6jrRMtMX284jKAJp6Gf9@lists.postgresql.org X-Gm-Message-State: AOJu0YwnQafsWz1NnJuoUPV4teQqkacriuqJSGYBJF4USMRl2Lw9udJF to6KZCXPJuMH7nMlNUpJLWocuQFcFTccCicYAEUSnh+tYK5iA3KDkMue X-Gm-Gg: ASbGnctEFG27nR5SFEpgdOlyOB8OJmd1nPmTkPzyiWebCz9ErevaK6z+ee3GouAqsI+ msmix6WO29CwxMTK9gcVXjGHkTIr8QPaj9137YFuCHNR2PvwUaNu5w57wR1jS0BWXMEc13RJx/9 n12qjO/nw5V4kTgSAWVPmKgqyasatfFYBwVVIb6OiQu7/qXpNvE8yirylE0OPSHhk0TCf3aIeju f8wYcJ/BoyBY3Xbx9BpU838eLUB7NJ/a5/W8YyuzKwjVtM55QY1EgGqV+vECnIbueYreKOjsFRw k77+KQUFfvRC+b5S/jciZYP/kHX1D0RAS3SRG+uSlJYnxVLOdqOc1iYmWSWHWmqMcS8tWtHfVjB MHfaBDG8Szka/XE2oI80WsuLh+2LofCFRLwqjmXOP37acaoNmfZApKLMu8AIA4bKRJ/dQ5SwaQ3 Jlb5xsoZuMW0nu X-Google-Smtp-Source: AGHT+IEpHFcwL+8XHb8eO/H7WaXbsuYsMCpZKkAPik5i4U1mXskppMxTMJZMSswimNVeBQUT8n8b6Q== X-Received: by 2002:a05:6e02:3184:b0:3dd:f743:d182 with SMTP id e9e14a558f8ab-3e3c529e1d2mr31688555ab.5.1753454074463; Fri, 25 Jul 2025 07:34:34 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e3cac99c5bsm364905ab.31.2025.07.25.07.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 07:34:33 -0700 (PDT) Date: Fri, 25 Jul 2025 09:34:31 -0500 From: Nathan Bossart To: Dave Cramer Cc: =?iso-8859-1?Q?=C1lvaro?= Herrera , Jacob Champion , PostgreSQL Hackers Subject: Re: More protocol.h replacements this time into walsender.c Message-ID: References: <202507251023.ddvb5pfuz6kf@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Jul 25, 2025 at 06:28:28AM -0400, Dave Cramer wrote: > On Fri, 25 Jul 2025 at 06:23, Álvaro Herrera wrote: >> Yeah, we could rename it, as in the attached. It doesn't harm anything. > > Consistency is good. If your patch were applied, then it would be > consistent to use WALData +1 -- nathan