Date: Mon, 28 Jul 2025 09:47:22 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: =?iso-8859-1?Q?Fr=E9d=E9ric?= Yhuel <frederic.yhuel@dalibo.com>
Cc: Corey Huinker <corey.huinker@gmail.com>,
	Bruce Momjian <bruce@momjian.us>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	John Naylor <johncnaylorls@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	Jeff Davis <pgsql@j-davis.com>,
	jian he <jian.universality@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>,
	Stephen Frost <sfrost@snowman.net>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	alvherre@alvh.no-ip.org
Subject: Re: vacuumdb changes for stats import/export
Message-ID: <aIeNeo-zGgevViNc@nathan>
References: <Z9R9-mFbxukqKmg4@nathan>
 <Z9jXuyymBSVDw9pv@nathan>
 <CADkLM=ek625v06WeeOpUNjGnCqyD8pH_0iYcCpg57KP3A8D9qg@mail.gmail.com>
 <Z9nnsPBlBzWxDuLi@nathan>
 <4b94ca16-7a6d-4581-b2aa-4ea79dbc082a@dalibo.com>
 <aITkuWC4Ww88GsFL@momjian.us>
 <CAKFQuwa2-oW__J7gAcVKgZnx658qBx9GknwL-wqX_0VvDc1EBQ@mail.gmail.com>
 <aIT9HMuQNIFfIlFH@momjian.us>
 <CADkLM=f9eYO_2f2LEf9a2zR_Zw9a4LtVAeqC_TdQEJdTuR-V+Q@mail.gmail.com>
 <8320fa2e-9200-46e2-b905-4a4d84707020@dalibo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8320fa2e-9200-46e2-b905-4a4d84707020@dalibo.com>
Archived-At: <https://www.postgresql.org/message-id/aIeNeo-zGgevViNc%40nathan>
Precedence: bulk

On Sun, Jul 27, 2025 at 12:46:44PM +0200, Frédéric Yhuel wrote:
> Then it seems very unlikely that the query optimizer's choices become
> transiently worse because of that, doesn't it? and this shouldn't be used to
> justify this option, IMHO.

I can't remember who wrote this line, but it was borrowed from the
--analyze-in-stages description.  The point is that if you use
--analyze-in-stages without --missing-stats-only, there will be a period
where existing statistics will be replaced with ones generated with lower
statistics targets.  Obviously, this wording isn't clear enough.  We might
need to either remove that sentence or add "When used in conjunction with
--analyze-in-stages..."

-- 
nathan