Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 30 Jul 2025 16:20:28 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrei Lepikhov <lepihov@gmail.com>,
	Greg Sabino Mullane <htamfids@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Nikolay Samokhvalov <nik@postgres.ai>,
	Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Subject: Re: track generic and custom plans in pg_stat_statements
Message-ID: <aInHvKN4Gsztmopy@paquier.xyz>
References: 
 <CAA5RZ0sxC0=2wZ-QaRB7FdMmQ4_BYKG=X+gdDGHnS6KTrfgLQA@mail.gmail.com>
 <1673684.1753379027@sss.pgh.pa.us>
 <CAA5RZ0sQuoHJsGc-dJV15yYURuXsOp2pwr9hLAk+pcm7=MAK2w@mail.gmail.com>
 <aILaHupXbIGgF2wJ@paquier.xyz>
 <CAA5RZ0t54uP+O2dGZCoYfzOU_wcT2trVL65GdZB00RiLDs9BCg@mail.gmail.com>
 <1933906.1753462272@sss.pgh.pa.us>
 <CAA5RZ0t4A4PVLHK5DPZWCsZvtviLf==PGG5eiy6Bm0DCpchHyQ@mail.gmail.com>
 <aIcWKh8wK2GWFMFz@paquier.xyz>
 <CAA5RZ0t6GctNqFA60_ajhw0D+9DeuHYa7F2QCQMumTxx=h3UZQ@mail.gmail.com>
 <CAA5RZ0sYd6-KeQqR4uLFS1swBh37jKJCzR_E-G373EuLKm5UzA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jFguxlePiNANDPmQ"
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0sYd6-KeQqR4uLFS1swBh37jKJCzR_E-G373EuLKm5UzA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aInHvKN4Gsztmopy%40paquier.xyz>
Precedence: bulk


--jFguxlePiNANDPmQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 29, 2025 at 05:08:09PM -0500, Sami Imseih wrote:
> The only comment I have is I think we need a NOT_SET
> member, so it can simplify the life of extensions that have code
> paths which may or may not have a PlannedStmt, such as
> pgss_store.

Okay by me for having a default that maps to something else than the
rest.

+   PLAN_STMT_NOT_SET =3D 0,      /* origin not yet set */=20

The term "NOT_SET" makes me itch a little bit, even if there is an
existing parallel with OverridingKind.  Perhaps your proposal is OK,
still how about "UNKNOWN" instead to use as term for the default?

> In pgss_store, I don't want to pass the entire PlannedStmt,

Neither do I.

> nor do I want to pass PLAN_STMT_INTERNAL in the call during
> post_parse_analyze, in which case we don't have a plan.

Okay.
--
Michael

--jFguxlePiNANDPmQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmiJx7wACgkQnvQgOdby
QH0gNw/9HLTs6Ud8OtH8uQmO5RgW5dtDybRMaC6cXuEhoMtFOaqIRTESRaEDjrwx
Dji86Jqod0/NU8ikXMSCn4kLNpPI/XstS/hvlkPhz+BT0uQewA7ske5Z8pWaY30v
INCNEHYziOlHedxnk6S9zGq3k+NTwVCasmtxZmaCtQL5Qa7Vhh+iwRjiBlTfCx/a
d6aprrCIADE/f3irMUNN7X2uO15664jeUfwuAJf87cVYBash/66nHkF5lla8ncy0
W4ZAGSVmJle7Kycm+4/nl2mbBcUWXChH/mbk1gk+VQcvEf+0XqLPwuhAlYMvgdhp
8n0a0fe0PAd7yniVvOf1FpiuNQeUj5KjcEm+IgVcrYthJJO2k/Tv7WMVuxEcoGcG
dpgFx4fghuQ5WWr7wakV9Cwny6ZR7qBA93+ohEcNOB+mEslA7DneZ3oO830DoYqB
xKrV/q8gJmrE3OEx9mk4pI9fI6zHC3O0+U2Z3WJlxENyzs+Le/4gqliPjKXtudSN
96kGyfioJXjf58Kde9Twsa4hFNk0opZnii3KD25/2upsbT+fg8Z0ipPCqY3/pzSW
GlkbfaUYsgseU9DyhGahhe23jAXXxW4VXxUWajxOKLirs521/k/ubkO7i8kN2vcr
LSgdBzjwkzzEpmzuPHcubfU7gyOmR8KOWNuqVE1eqfmsmrHBJGY=
=AUO5
-----END PGP SIGNATURE-----

--jFguxlePiNANDPmQ--