Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 7 Aug 2025 11:51:37 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Joseph Koshakow <koshy44@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: date_trunc invalid units with infinite value
Message-ID: <aJQUuQw0mDfGRig-@paquier.xyz>
References: 
 <CAAvxfHc4084dGzEJR0_pBZkDuqbPGc5wn7gK_M0XR_kRiCdUJQ@mail.gmail.com>
 <Z1E7cTyVbFZJwUWf@paquier.xyz>
 <Z2pj22b9qZryFIRo@paquier.xyz>
 <Z24wLjuagL5T4hOC@paquier.xyz>
 <4bf60a84-2862-4a53-acd5-8eddf134a60e@eisentraut.org>
 <aJPuAadlimgSac5I@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/sPBWkvl9oc/Hqd3"
Content-Disposition: inline
In-Reply-To: <aJPuAadlimgSac5I@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/aJQUuQw0mDfGRig-%40paquier.xyz>
Precedence: bulk


--/sPBWkvl9oc/Hqd3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 07, 2025 at 09:06:25AM +0900, Michael Paquier wrote:
> Yes, confirmed the broken case on 32-bit builds with the incorrect
> result returned by timestamptz_trunc_internal():
> SELECT date_trunc( 'week', timestamp with time zone 'infinity' );
>=20
> 0001 four new tests for timestamptz:
> 1) Three tests for timestamptz_trunc():
> - TIMESTAMP_NOT_FINITE + a valid unit, new path.
> - TIMESTAMP_NOT_FINITE + "not supported" unit, new path.
> - !TIMESTAMP_NOT_FINITE +

Blurp here.  I meant !TIMESTAMP_NOT_FINITE with unsupported unit, old
code path.

> 2) One test for timestamptz_trunc_zone():
> - !TIMESTAMP_NOT_FINITE + "not supported" unit

There can be an extra test here, for the case of an infinite value
with a valid unit and a time zone specified, which would also have
failed with the bug as timestamptz_trunc_internal() is also used by
timestamptz_trunc_zone(), like:
SELECT date_trunc( 'week', timestamp with time zone 'infinity', 'GMT')
  AS inf_zone_trunc;

I have added one more test, reversed the order to avoid spurious
failures should one have the idea to do a bisect with a 32b build, and
applied both things.=20

Thanks for the report!
--
Michael

--/sPBWkvl9oc/Hqd3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmiUFLkACgkQnvQgOdby
QH1vmA/8DC/qSAQmMxd5GBnEHr+U4eDy+N7RaTKjDmPwoZkgDwOC2DNjctZr65Nd
rRUpQuosz8WyMVBPsyw9puW6vTE13j0cD7ghUfZ1S99tDPKrK6zUwntaVwEhbrAa
/MUOh5HuwZVU/ba7LMIGb/i1LZ1lMS1SPDANIy7mwKhgZJd51QQtJtEYEj+nUyxb
jVIOIlLLih5vpG39B6YoAmsbvxtnlJy1YdccADNHIzudK0c4kgRZhnrgRuxCr1Wf
Jdn88n81HHXmhvDrxj14vGQijljRcds5+8ujLUMn4YuzZ4ssA+InKua3Q9pWwq+W
EVB6N6njrfCgCYBPS9T4gf3m1tTGEuguiZIvQmFrm+RbHLAbgs9iPxrXRnkesLvR
vGMemy9L3CLmWyDQQtVDzTP2cdTZTW+8O0bCvC6JNOXGhLPaVfSPelm/Y5+WFuLa
5QdFdbi5ObHtjCB6V7oVt7t+/N12l581Og8KTonnxG+lZJz+Qbr8UZFBimcytYEY
uF7aDVpibMtMlsKBqktjjxpWlGn1Hl29Zdwl5tYff+f6XOl5HIRNzMdjapY9h4vn
f3HGJJERJweHm8LZFnm6zlto9Rh9Fa82mCHSOAP1LHBIAIlvD5IEXL/unIvGmCov
4Cxoc7bnrJnz3yNgccnsMIpZCKIYnSz16lZwnjw7bebUZgmyx2c=
=VtB8
-----END PGP SIGNATURE-----

--/sPBWkvl9oc/Hqd3--