Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ujvod-00Djqh-Cx for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Aug 2025 08:17:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ujvob-0038c0-K7 for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Aug 2025 08:17:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ujvob-0038bs-5L for pgsql-hackers@lists.postgresql.org; Thu, 07 Aug 2025 08:17:33 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1ujvoY-001Dtk-0Y for pgsql-hackers@lists.postgresql.org; Thu, 07 Aug 2025 08:17:32 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3b7892609a5so373079f8f.1 for ; Thu, 07 Aug 2025 01:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754554649; x=1755159449; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/Zdi6Iv/B+NASTsCEOk3um1y+IWFw/ysmqcURHkl6B4=; b=aeu0Q+HuKiM43tWONKtaTg3O46GvkkG5Aa8Iop2HEWtGQ76dKj9UN/PCtpaCVk4BjM rIcc8VW8PUEciNJc8J5r3k9lkEP0zZ9s1y7HoT6uvRFLYocJmoh61QQW5lFyfR7z8BDi TJuafFdkDGVVEi4OAKP+RNua3DeGXztQ7pJFlR/QQPOivYbpgKqQwctlNXTqMhPVXu2+ 5Kg8JSFTmOk6i3e52ArjTWM9+P+2QDfB5iU4nMDSN0ziQT+Eojtd/b36hhoG2/2wef6S 9d3aWwhrvaB9O7gJaX5+PNAKlus786kRZajcM9CILrkeY349HP9kHa6zVJkirFhc08yF o3vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754554649; x=1755159449; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/Zdi6Iv/B+NASTsCEOk3um1y+IWFw/ysmqcURHkl6B4=; b=U3W41j0aCCOh7ooIPasExegy6lWFNcrvsR5VccMOW4ybGsgg1HnWy6srPOBGOnRkc8 fnNk3k3bpmJnaKQp+4xXuzDTPJUtyatAFNOdyVMVeCJ1OssOHVRXnO+DtYKio12nwK9X ffa2wFEdMI6I0X7JboNKmcd3utCA4mL0knbPmwk0NzftoFRY7LSefZYud0zrt6MVo8sD cDiW2MumtbI4qr2y+03yGpoSJDhwLtRiRgIkhnu6b6Fal72rELgf/AoxKA5f3XyYvVXy TRQTw9poZWgdu44oTAOE6WQxevr35UEKhugodVaAMbUi4dhnBSiDq25ooHKDwQ5/NXO0 x34w== X-Gm-Message-State: AOJu0YwreE+5N+L3ESdiJWOKQAvADB0epoQ8SklzJMRiwMIALXcMC2mw A4QvjeLHAmEaJbADGT6CVdkN4voMFmbIapWXdO9KkvvdgsFPPzsiHjwtdtv++w== X-Gm-Gg: ASbGncv4fOE0QZ2NxMcFJoEkFJMkL/gsDiwKLCMJkP4uhrUdrqLDboeoZ158KKF7VSK AqEI4kSMIgjV25TTrf2uy5VGg9x1i6Qn14NtodT8t9AvmbFaswS5dzHWhHOR30FZhyAihVp8V+L x/ZhqcgO29M7boGjdZoU+O+WZLEh3zqDMoXta9hG6Powr+hxhNH/5epjb/MsqBU9ZePjHp9GiO7 hZ42/FtNNindT90KEnqYTbxv/j14ITCpfoBW0y3Xt3Ckf0Y1S5+5ErmYDiwWANxaZQICns9mABm uxZ6WaAbN33YAnyyL96rwrfedpesfZvCNYkwdq7IFIoLjDYFCm16NXrJDZIZRG98iTIRRE9WoLE hDz1aljFKRueY30xUJtBKWBX3LEWtI0+TkdNnHeHfkKv2K53haoNT41Hs7n6o8s85O9UNadMFfn GDYj0jwmj1xck6umUQL9GeuLI5J4Py/2oCeWH779OsLqSemPDlemEGFg== X-Google-Smtp-Source: AGHT+IF7q1N3lLuVGp0Tm7N6F+ksZMqF3fQGn68xzunL530vtstnLa/nsRmcN9wqo8eFRiIn8e+UtQ== X-Received: by 2002:a05:6000:188b:b0:3b7:8a28:3e35 with SMTP id ffacd0b85a97d-3b8f9f20d1fmr1458920f8f.2.1754554648850; Thu, 07 Aug 2025 01:17:28 -0700 (PDT) Received: from ip-10-97-1-34.eu-west-3.compute.internal (ec2-15-237-181-182.eu-west-3.compute.amazonaws.com. [15.237.181.182]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c3b9386sm25848846f8f.18.2025.08.07.01.17.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Aug 2025 01:17:28 -0700 (PDT) Date: Thu, 7 Aug 2025 08:17:26 +0000 From: Bertrand Drouvot To: PostgreSQL Hackers Subject: Re: Adding per backend commit and rollback counters Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="SywurcztURg2uk+W" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --SywurcztURg2uk+W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Mon, Aug 04, 2025 at 02:20:48PM +0000, Bertrand Drouvot wrote: > This patch is pretty straightforward as it relies on the existing per backend > statistics machinery that has been added in 9aea73fc61d (so that there is not > that much design to discuss). Still, while working on adding more backend stats (more on that later), I realized that in v1, I missed to use pgstat_report_fixed (recently added in 793928c2d5a): the attached fixes that. Also, I think it's better to put the new xact pending counters in the existing PgStat_BackendPending, done that way in the attached. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com --SywurcztURg2uk+W Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v2-0001-Adding-per-backend-commit-and-rollback-counters.patch"