Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 18 Aug 2025 15:49:41 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Naga Appani <nagnrik@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	Kirill Reshke <reshkekirill@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: [Proposal] Expose internal MultiXact member count function for
 efficient monitoring
Message-ID: <aKLNBdQc-tCFMszs@paquier.xyz>
References: 
 <CA+QeY+AAsYK6WvBW4qYzHz4bahHycDAY_q5ECmHkEV_eB9ckzg@mail.gmail.com>
 <CA+QeY+CuTcKSFmw3H-_OtCv+bv0T4uTSFgaAY1N9ssL-WaiiSA@mail.gmail.com>
 <CALdSSPi3Gh08NtcCn44uVeUAYGOT74sU6uei_06qUTa5rMK43g@mail.gmail.com>
 <CA+QeY+DTggHskCXOa39nag2sFds9BD-7k__zPbvL-_VVyJw7Sg@mail.gmail.com>
 <CAExHW5uxBnodmpXygUQUxZAyxYvbXczadxGOVeL=0DxpkXUR-g@mail.gmail.com>
 <aIb67MiYhVy7gwV-@paquier.xyz>
 <CAExHW5vba_ecL2c27giAOOaRxoNdVX2BNQVCN4PFOZJC17NrqQ@mail.gmail.com>
 <CA+QeY+CFLjh0gb-j9p+0eJK=r19izhEPCBY3ns4+HCgOQojh8Q@mail.gmail.com>
 <CAExHW5s5hnxKK_VE=q94sN8uU5BJCRpAescGuamheuM-Ua559A@mail.gmail.com>
 <CA+QeY+C3tc12wWX56yHozLYK=MmCkn1fODzFWC6-dSY+TZghTQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="XqvNaHFP1p81nPZB"
Content-Disposition: inline
In-Reply-To: 
 <CA+QeY+C3tc12wWX56yHozLYK=MmCkn1fODzFWC6-dSY+TZghTQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aKLNBdQc-tCFMszs%40paquier.xyz>
Precedence: bulk


--XqvNaHFP1p81nPZB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Aug 17, 2025 at 01:27:29AM -0500, Naga Appani wrote:
> On Thu, Aug 7, 2025 at 7:35 PM Michael Paquier <michael@paquier.xyz> wrot=
e:
>>
>> I really think that we should move the SQL function parts of multixact.c
>> into their own new file, exposing ReadMultiXactCounts() in multixact.h...
>=20
> Done. The SQL-callable code now lives in
>   src/backend/utils/adt/multixactfuncs.c
> and the accessor is declared in
>   src/include/access/multixact.h.

My point was a bit different: multixactfuncs.c should be created first
because we already have one SQL function in multixact.c that can be
moved inside it, with the declarations it requires added to
multixact.h.  I've extracted what you did, moved the existing
pg_get_multixact_members() inside the new file, and applied the
result.

>> ReadMultiXactCounts() is also incorrectly named with your proposal to
>> expose oldestMultiXactId in the information returned to the caller...
>> So perhaps this should be named GetMultiXactInformation() or something
>> similar?
>=20
> Renamed to GetMultiXactInfo().

+ * Returns information about current MultiXact state in a single atomic re=
ad:

This comment is incorrect.  This is not an atomic read, grabbing a
consistent state of the data across one single lock acquisition.

Except for this comment, this looks pretty much OK.  Ashutosh, any
comments?

I have not looked at the rest.
--
Michael

--XqvNaHFP1p81nPZB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmiizQUACgkQnvQgOdby
QH1CTBAAhbT2puItdDQhRIwvE1MGl0BZWz/8IBGCxDNSLP+so2EnR4eZN5ojELhI
ztIgvaB3sXYYaCHBYbGRCeBxtRTDjEmmRLWgqq79PF+sTm/TtrXZNR23kjY1A2SZ
fbW5EcFMEFC+/Q63Lrw4K5f1OGMyLTpG61KmMNDLD5GL7jmNnCEwzetsdJTxMrxw
k9tLmSPsvlHwCYg9r6YvupJGXrZpqAdtHAfD2mzJNWcbaqz+9/BXjGJIeqXL3wYx
VU6KE72ghgBbftp2qd1Kid72CiQ9eXA/gvVnn44cXfb4lqeduYNI7QSiEP1N0nSV
xnpHKWMcweh0yiApr3QYCr5KdsQEhFhyOZCwFIdHKpgVzr5WxJS39xwMVR7IWswB
Q/xC/HXeaCJPaQxfx9sND42zE3WtIAc8XuTeIfQI5JPWqMViSQcW5Dc1ABQr7hOs
GcdH95sWcSvSZvc0gOZLyX8teVnQeLBtGr1bZ4oZwLDHiLo/P52Mg/DYwUJg0StS
9xTtgk2yhYfz80wFFVaGvt2BimYU1e0tlvxFqFRlXkGcfPDhj/OZnw3uRrCzjt6C
oKy6HoAa5BQKtMUinh2xZ5VvFmSWwaSYex4XXcuhatVDiha/kxR9DhyQioI4Ny8l
mRQKIh0aFYPCNndHaNN4MqBZZXfoZAhY6j7Rlq3rOXkBjQ6RuAE=
=v8Lc
-----END PGP SIGNATURE-----

--XqvNaHFP1p81nPZB--