Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 19 Aug 2025 20:17:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: 'Paul A Jungwirth' <pj@illuminatedcomputing.com>,
	Mutaamba Maasha <maasha@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	"Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: ReplicationSlotRelease() crashes when the instance is in the
 single user mode
Message-ID: <aKRdXV8o56mUl_gm@paquier.xyz>
References: 
 <OSCPR01MB14966FCE16ECCF29AE0502AF2F5C42@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <OSCPR01MB149660520A0E53CC53E8B66F1F5C42@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAA4eK1LK5nZUWwNY31X6BUXdQwwzpKGKxnw+zFf-cWKm3nuCEg@mail.gmail.com>
 <OSCPR01MB149669CFD736D48C4450337DDF5CD2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CAA4eK1L8_QrYavkCy9b0Rrz8gqZRQE8kEmv3g7Tz6tsN8YuvhA@mail.gmail.com>
 <OSCPR01MB149660CD4D6648CFE7FE68D34F5CC2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <CA+renyWi+bbD8M8CDAaOMGbUrXptKLCK8zQWEhXy00PJuJqNuQ@mail.gmail.com>
 <OSCPR01MB14966B39B3ED21229EAEFA10FF531A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
 <aKLsJljQOnjBwFZQ@paquier.xyz>
 <OSCPR01MB14966D87D8EB0D9CD32C6A43DF530A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FU/aEACb3LwT3C52"
Content-Disposition: inline
In-Reply-To: 
 <OSCPR01MB14966D87D8EB0D9CD32C6A43DF530A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aKRdXV8o56mUl_gm%40paquier.xyz>
Precedence: bulk


--FU/aEACb3LwT3C52
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 19, 2025 at 10:26:22AM +0000, Hayato Kuroda (Fujitsu) wrote:
> I added a first version of the test. It could work on my env (Linux).

You could also validate that using the CI, assuming that you have a
cloned repo on github with the CI enabled.  See src/tools/ci/README.
I use that a lot with local branches for pre-commit validations where
things could break across the board.

> Since I cannot come up the appropriate place, I introduced new test file in
> recovery test. creating/dropping/advancing a slot, and doing a logical decoding
> is tested. Since standby mode is not supported by the single-user instance,
> I did not test the slot synchronization. I have not known that.

Hmm.  src/test/modules/test_misc/ makes more sense to me here.  (No
need to send an updated patch just for that.)

> IIUC, 0001 can be backpatched for all supported branches. I will create for them
> after patch would be a good shape.

Thanks, I'll check all that tomorrow.
--
Michael

--FU/aEACb3LwT3C52
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmikXV0ACgkQnvQgOdby
QH1oUg//ctcdimmlLnN2n8RTm8pmmuymY41lVGWX8NnQzrxkSnGG0f3zbh8WbpcI
JYQGJEpvyV1NktbrG0wJV0rL4g2z2sQTU8F1XYhuX2GNFfdh/m7Vit9C2FhQzRZ5
gVm4bfDEutw5HuZR+xsRFyrS+owwpCzn+oRvs8KEdaYowB379idjNAHU84wBn1r4
gk0HWbbTVoBfwIVcXCvyDAw6RyDlWNA5SYUMZWS11hsooFqko2NDayIY3cw2/Jah
hbNjy6EKDfD1kTWN53hv+LDrlPCOWUFFyKqedKrTkU7vgX/aaiegaPKOYZbxIDmE
EErTgTxhrEPvasWyFz/1VD1PDGVtHQrbuiRRfK8XlrKsCdHrnukrMEWg3riKxJiI
a+f7DcH13eoVjgEGdIdI913otAlUZeMnL7jMD8Mb64boyUiJJJN5xAkPLKWxAnFx
mwAqanoJlJhIJTRO02utTk4nj/O3wwshb2GnjEaOUuZV1AEtGPgwDh4hpHpke/pl
0e5uuvK7ExMPK1GiEtqSz0t0MxzDiuT/duibckFQx/TNOSqe1ZiVeBQJ+rCwHU44
oJwEMuenQh1sjHENdHIqUzraPWzFBsIeVHdkJKB2QwsswUut0pR2/rfKb0nBck+s
Xq5GwWFV8NGIlMtMT+FLdfJPc719cqZ3syJsz6yKBaeFZS1OyT8=
=cdvk
-----END PGP SIGNATURE-----

--FU/aEACb3LwT3C52--