Date: Mon, 25 Aug 2025 15:33:08 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Sami Imseih <samimseih@gmail.com>, Andres Freund <andres@anarazel.de>,
	Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	Rahila Syed <rahilasyed90@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Improve LWLock tranche name visibility across backends
Message-ID: <aKzIg1JryN1qhNuy@nathan>
References: <5to6tftuml6nkas4jaaljfzecasvslxq3mumeslh74wsol4mzw@rgxpxxlqqwtf>
 <aKTGF9Fv1ioXa9P5@nathan>
 <876523.1755635201@sss.pgh.pa.us>
 <CAA5RZ0sbo-HAOrTGVoqP3giXKDV_LXL0UGaYs8mfjcS33mn3FQ@mail.gmail.com>
 <aKTlu7mHhx4owx6r@nathan>
 <CAA5RZ0tg0-O3KVrP9UrZWm18OECxK87WNJo=cZy=Gevc+Ui5oA@mail.gmail.com>
 <aKTqiofwo1Eif_3w@nathan>
 <CAA5RZ0tKoQeTuRsFmUjPAOEXBiyEGyePsqCAy-_oX4eFHSCmHw@mail.gmail.com>
 <CAA5RZ0sUy38M2q0ML0v27hA=gZzZGdjbqv-vGyh_nd8o43Q4pA@mail.gmail.com>
 <2151672.1755898435@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2151672.1755898435@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/aKzIg1JryN1qhNuy%40nathan>
Precedence: bulk

On Fri, Aug 22, 2025 at 05:33:55PM -0400, Tom Lane wrote:
> Sami Imseih <samimseih@gmail.com> writes:
>> One point I did not make earlier is that the tranche name lengths will
>> need to be as long as we allow in dsm_registry.c.
> 
>> #define DSMR_NAME_LEN 128
> 
> Huh.  Why is that different from NAMEDATALEN in the first place?

One of the reviewers of commit fe07100 requested it [0].  At the time,
there was no reason to use NAMEDATALEN.  I'm fine with lowering it if
needed for the shared tranche name work.

Presently, we also append a " DSA" suffix to the DSA tranche name in
GetNamedDSHash().  I was originally trying to use separate tranches for the
DSA and the dshash table for observability purposes, but since it seems to
be more trouble than it's worth, perhaps we should only allocate one
tranche.

[0] https://postgr.es/m/58DB9EB7-4646-4508-84BA-F0F067A7E8BA%40gmail.com

-- 
nathan