Date: Mon, 8 Sep 2025 14:59:36 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GetNamedLWLockTranche crashes on Windows in normal backend
Message-ID: <aL81qInOS3GQWwBm@nathan>
References: 
 <CAA5RZ0tuKYaaS3ohjqXzxgk7xExz1VdP4Xyay9YxemJWr4vAfg@mail.gmail.com>
 <CAA5RZ0tUApqNpYbRq9dtWZZyWd8FhJxxjOLbU8yso=opJMuHtQ@mail.gmail.com>
 <aKzYgi0TbmcG-Y9l@nathan>
 <aLi075cWNyXQw-6G@nathan>
 <CAA5RZ0uCPdEngGPceCuqpOkeDR7uHA30M5hONhkJdcrmk+KLjQ@mail.gmail.com>
 <aLndPXAnzeCy7C3T@nathan>
 <CAA5RZ0uWH1owL9NG6GkbvVh_CjFN5nvzExoSddDLWEJxRBNimA@mail.gmail.com>
 <aLo-UaLpNwROh8uJ@nathan>
 <aL8KcsrCdPhDBmps@nathan>
 <CAA5RZ0vpr0P2rbA=_K0_SCHM7bmfVX4wEO9FAyopN1eWCYORhA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAA5RZ0vpr0P2rbA=_K0_SCHM7bmfVX4wEO9FAyopN1eWCYORhA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aL81qInOS3GQWwBm%40nathan>
Precedence: bulk

On Mon, Sep 08, 2025 at 02:47:26PM -0500, Sami Imseih wrote:
> I think v2 is fine because it is perfectly fine for a normal backend
> (EXEC_BACKEND) to call this function as long as it's processing the
> startup hook. The goal is to prevent it from being called outside of the
> startup hook.

I thought the goal was to prevent the crashes...

> I think we should commit these tests as well. If  you think the tests
> should be a separate thread, let me know.

Thanks.  I think we can discuss them here once we fix $SUBJECT.  (BTW it
looks like you forgot to attach the patches.)

-- 
nathan