Date: Mon, 8 Sep 2025 15:14:01 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Jeff Davis <pgsql@j-davis.com>, pgsql-hackers@postgresql.org
Subject: Re: Should io_method=worker remain the default?
Message-ID: <aL85CeasM51-0D1h@nathan>
References: <d68e2a4f8c356107e5167408ad80eaa2fac0f57d.camel@j-davis.com>
 <adywrhdn5zcfeldzug2pkzbdxizactr46goh4doiztvexrqomy@lgvl26gui63a>
 <a81f2f7ef34afc24a89c613671ea017e3651329c.camel@j-davis.com>
 <1b50102876dc9564049c985cff0ec1903cc8d502.camel@j-davis.com>
 <cmrpnnmbd4tajrg3lfnvzfo224siwyxzc6homaf2bvpmabiln5@jzfsvlsyoqtj>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cmrpnnmbd4tajrg3lfnvzfo224siwyxzc6homaf2bvpmabiln5@jzfsvlsyoqtj>
Archived-At: <https://www.postgresql.org/message-id/aL85CeasM51-0D1h%40nathan>
Precedence: bulk

On Mon, Sep 08, 2025 at 01:43:45PM -0400, Andres Freund wrote:
> On 2025-09-05 16:07:09 -0700, Jeff Davis wrote:
>> On Fri, 2025-09-05 at 13:25 -0700, Jeff Davis wrote:
>>> As an aside, I'm building with meson using -Dc_args="-msse4.2 -Wtype-
>>> limits -Werror=missing-braces". But I notice that the meson build
>>> doesn't seem to use -funroll-loops or -ftree-vectorize when building
>>> checksums.c. Is that intentional? If not, perhaps slower checksum
>>> calculations explain my results.
> 
> Yes, that's an oversight.
> 
>> Attached a patch. I'm not sure if it's the right way to do things, but
>> the resulting compiler command seems right to me.
>> 
>> It doesn't affect my tests in this thread much, but it seems best to be
>> consistent with autoconf.
> 
> Yes, we should do this - the patch looks good to me.

I think we need to do something similar for numeric.c.

diff --git a/src/backend/utils/adt/meson.build b/src/backend/utils/adt/meson.build
index dac372c3bea..7d0688ddb87 100644
--- a/src/backend/utils/adt/meson.build
+++ b/src/backend/utils/adt/meson.build
@@ -1,5 +1,14 @@
 # Copyright (c) 2022-2025, PostgreSQL Global Development Group
 
+numeric_backend_lib = static_library('numeric_backend_lib',
+  'numeric.c',
+  dependencies: backend_build_deps,
+  kwargs: internal_lib_args,
+  c_args: vectorize_cflags,
+)
+
+backend_link_with += numeric_backend_lib
+
 backend_sources += files(
   'acl.c',
   'amutils.c',
@@ -61,7 +70,6 @@ backend_sources += files(
   'network_gist.c',
   'network_selfuncs.c',
   'network_spgist.c',
-  'numeric.c',
   'numutils.c',
   'oid.c',
   'oracle_compat.c',

-- 
nathan