Date: Mon, 8 Sep 2025 11:55:14 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GetNamedLWLockTranche crashes on Windows in normal backend
Message-ID: <aL8KcsrCdPhDBmps@nathan>
References: 
 <CAA5RZ0un+WRqsM35JUE97LOdrjGbE1VZpL0h0kaQn-_y5j8U0A@mail.gmail.com>
 <aKyzQuljgqo7-YIs@nathan>
 <CAA5RZ0tuKYaaS3ohjqXzxgk7xExz1VdP4Xyay9YxemJWr4vAfg@mail.gmail.com>
 <CAA5RZ0tUApqNpYbRq9dtWZZyWd8FhJxxjOLbU8yso=opJMuHtQ@mail.gmail.com>
 <aKzYgi0TbmcG-Y9l@nathan>
 <aLi075cWNyXQw-6G@nathan>
 <CAA5RZ0uCPdEngGPceCuqpOkeDR7uHA30M5hONhkJdcrmk+KLjQ@mail.gmail.com>
 <aLndPXAnzeCy7C3T@nathan>
 <CAA5RZ0uWH1owL9NG6GkbvVh_CjFN5nvzExoSddDLWEJxRBNimA@mail.gmail.com>
 <aLo-UaLpNwROh8uJ@nathan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aLo-UaLpNwROh8uJ@nathan>
Archived-At: <https://www.postgresql.org/message-id/aL8KcsrCdPhDBmps%40nathan>
Precedence: bulk

On Thu, Sep 04, 2025 at 08:35:13PM -0500, Nathan Bossart wrote:
> On Thu, Sep 04, 2025 at 04:12:09PM -0500, Sami Imseih wrote:
>>> Yeah, I think modeling this after commit 4f2400c is a reasonable thing to
>>> explore.
>> 
>> Here it is as described above.
> 
> Thanks.  This looks like the right idea to me, but let's give some time for
> others to comment.

I've started preparing this for commit, and I realized that restricting
GetNamedLWLockTranche() to shmem_startup_hook is not sufficient.
EXEC_BACKEND builds will run this hook in every backend, so unless it's
guarded behind some sort of "if (!found)" condition (i.e., only run in the
postmaster), it'll still crash.  I think we just need to add some extra
notes to the docs and check for !IsUnderPostmaster, as discussed upthread.

-- 
nathan