Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ustok-00Chw4-Ou for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Sep 2025 01:58:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ustok-003cIS-7y for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Sep 2025 01:58:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ustoj-003cIK-UG for pgsql-hackers@lists.postgresql.org; Mon, 01 Sep 2025 01:58:46 +0000 Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1ustoi-002lIY-0k for pgsql-hackers@lists.postgresql.org; Mon, 01 Sep 2025 01:58:45 +0000 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.stl.internal (Postfix) with ESMTP id BCA557A01D6; Sun, 31 Aug 2025 21:58:43 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Sun, 31 Aug 2025 21:58:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1756691923; x=1756778323; bh=mV04FMAdX6 nUBROLUVbDrqa34DnCkUbs4y7HJj5k6x0=; b=mGm5nK7FuurEof3nbhgkpxsoKU OYX2o32qzLRcvp5TEQ0Gk3HkyFY541yo93F0Ie7RgCU3+oGQfLws0z2nHJ6PNDz4 BzqrCINDq5cRs5dFWa3mDhGJg0sS+UN7IXgo+XVj+sZA08juUs4pUtNor+36fe3x vMr3W3zSRn3G0t8YRXmCTUIpcM14gSVWCJOv1gOyruuGLCxBroSjUzyhhhaM2JZe kre9R+yWkiVrM6gtWtsgv0hjRelBGETOY6VOtbbefntATw5aM8Wl3xzIMBWZShCp 3rfdTTe2ZpZajdN7GFslONQAFPxY3dAJYIApMTSO1BHsKShOKHwwhz+hoR2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1756691923; x=1756778323; bh=mV04FMAdX6nUBROLUVbDrqa34DnCkUbs4y7 HJj5k6x0=; b=FXAuyoyct7NA9SHgj1Tz13Gh2jOfYjWrRfehGToUZS3XPTI/rDO 4Z1l76z0pMf5lUBhwQ+pSh8VaTnktqqaBwiQrFTzxT0M6ZE9bsA3Ohygq1toBpHM Tr1Cs+E/04knHKmTbU3TdvHgGMDLQu4lizrzdB1pXgitLQcsyapcnMkSw6zVFItT o7vuqSpyA3rQPwQV50bavossHKQW2LtYC095ynHJ9dyhtsD7UcScAmwYenV8rn21 7zA/4C6Za61mG6/nVEyZfqjpdUm+RSdnMbg4GpaIWh8VgBvrpD/FNCg7K6HnhPQ9 CFnRZlsWcOp/c+6X8wFZWxIbxg2udP+rjlw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduledtkeelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrh hlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeeg fffhkeeuveetiefgudduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidp nhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggrnh hivghlseihvghsqhhlrdhsvgdprhgtphhtthhopegrnhgurhgvshesrghnrghrrgiivghl rdguvgdprhgtphhtthhopehjrggtohgsrdgthhgrmhhpihhonhesvghnthgvrhhprhhish gvuggsrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdr phhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 31 Aug 2025 21:58:41 -0400 (EDT) Date: Mon, 1 Sep 2025 10:58:29 +0900 From: Michael Paquier To: Daniel Gustafsson Cc: Andres Freund , Jacob Champion , Pgsql Hackers Subject: Re: Serverside SNI support in libpq Message-ID: References: <88986722-5A72-4DEC-8750-BDBF67FF8C01@yesql.se> <7E77028B-5A3A-436B-9046-8E9992E9F94A@yesql.se> <0BC5B9B1-6503-4563-AAC6-33DEF264AE3F@yesql.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YmfVT/uf0W1o3NBr" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --YmfVT/uf0W1o3NBr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 27, 2025 at 09:49:34PM +0200, Daniel Gustafsson wrote: > When looking into why the SNI tests failed on Windows I think I found a > pre-existing issue that we didn't have tests for, which my patch added te= sts > for and thus broke. >=20 > The test I added was to check restarting and reloading with ssl passphrase > commands (which we do have testcoverage for) with a subsequent connection= test > to ensure it didn't just work to start the cluster. Would this part be better if extracted from the main patch and then backpatched? Even if not backpatched, a split would be cleaner on HEAD, I assume, leading to less fuzz with the main patch. -- Michael --YmfVT/uf0W1o3NBr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmi0/cUACgkQnvQgOdby QH2K4w//Srv3R50G1PH/MNg8eEEm921iYR4Ojny4Qt+4oRi8iQ9A97lcG7armxu7 EXXYCQaFkO35hl+3ZaCvIX2wu4867nSPiUMxxaTOjU21aNFFyy90WqOJaRqDmR2K BM7Ntn2mUxYxFdsXFeDnq51ln90XCvpfOQe+RWjYxMyhCTQ7hSe1RhNIk4iWG2wv qP4aZa4xPXmkpdCCVA2xrq+d/B7KGqmpHawgQfp9Go7B0LMaj0qTtGTdvhCorhIY C82HLR+cVF/Hvl+Wr0TTGTZ+4m6gb04tl5K9TqDm1g6gy48SsbVm5O1U3/7psLNu ouIxI7Zp/5ijoZLTHOlZmo3vFnWeEU7/l5P1ksIHrryCPkdXxS4g6TEmPzPPYCpu bI/gzQLwmneufWZzjTUMVr4wTf+ZSLhvrNYu0C7/sRa6i4lMQzNLAngqweJxX5rH V16o5YQD+oQ3xJLzF312P6LUTUOcYKhOvt8TUI+OVRXjibw435MYwA2LWtBQMN02 epTx9KMFzQ4qvuQRmGy0hXYW3aCsswy+6z4Wxl8VWFJYjwsV8p+qLY++d01ljwq8 +BGcheG+uv3fbYE894zSQSZfpMdI+RawSas9e0QHSc3Zo45iJ1wMbywHSv1bWV3Z F5g+NDojVwS+bAya1rN+6YmfLZLUd+nzDLG8nH+CSLuyHd3wFOg= =rAAL -----END PGP SIGNATURE----- --YmfVT/uf0W1o3NBr--