Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uswkB-00DS1C-44 for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Sep 2025 05:06:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uswk9-004RBT-JB for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Sep 2025 05:06:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uswk9-004RAE-9T for pgsql-hackers@lists.postgresql.org; Mon, 01 Sep 2025 05:06:13 +0000 Received: from fout-b4-smtp.messagingengine.com ([202.12.124.147]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1uswk6-002mcH-2m for pgsql-hackers@lists.postgresql.org; Mon, 01 Sep 2025 05:06:13 +0000 Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfout.stl.internal (Postfix) with ESMTP id 3A5A61D001E0; Mon, 1 Sep 2025 01:06:10 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Mon, 01 Sep 2025 01:06:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1756703170; x=1756789570; bh=UHNwFvydBC G5QQykPJAQYy0zvdyaTh14j/E30ImnCjI=; b=EDJfFni3n8CUT0rqpyu73t8KyD pCS2pRqQKr6YyYVtqU6tnmfXyI1+j9V7S02uqSvNvg9pw92L2O+Kr0KFlXCmF8EC aEw8s2+b8ntsbnigyT/YHFGwTeHakMb45a/crX1+3DiqJtDJTSz3p4YY/N+87eni jsvSiCIPXbYSmwa9PqY+hI2BxQgoU3QdLxDTaquzrruST6stPojV5wyo8orDSlzr L7u6zzwxe4twuvGO4n/9c1c1/vjzc7A4CmEA0R1IiPcCtg+AAbK5qWWiTYVMdM3E 7Yk/h6kJ6A2E/uvUYJlQkxxNgTC2n3YQee5jdyL6JzWzxLrn1XnpXt/OjxEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1756703170; x=1756789570; bh=UHNwFvydBCG5QQykPJAQYy0zvdyaTh14j/E 30ImnCjI=; b=fd2kzxo86OBo5eaFYIQQo2VDfIiSScqqO5lj0EbWEVbYj8LTP1g giEkV9+XTaozJ1thWjJPNE1dqm+RRIoOVC+pLDFERVfLAFAaNhJmqP3JTOOSgpHI IFC1SenFgcI21Kort5O2kHVhgbdBSaWgQd7OPGC3VipCgossgsnv4nJXpJsoqzv+ pGs3WIKyPQkOzdv6CML+8a6bQCEsfy0Ey+km/JCc+3oLd8Y1L3VCNW0wY2/wsgEI r95Fw2vbRbW7TXIlc+LdWBNDxNgBw7k6SgrfvNuBWj9LF3AisF/fqcfV+EjBGPJ/ 4W3YOym3WLiJeQb77Msyqnr+o7jt1EWNUHw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduleduvdejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvve fukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhi vghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnh epteelieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdejnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrg gvlhesphgrqhhuihgvrhdrgiihiidpnhgspghrtghpthhtohepvddpmhhouggvpehsmhht phhouhhtpdhrtghpthhtoheprhhjuhhjuhduvdefsehgmhgrihhlrdgtohhmpdhrtghpth htohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdho rhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 1 Sep 2025 01:06:08 -0400 (EDT) Date: Mon, 1 Sep 2025 14:05:56 +0900 From: Michael Paquier To: Julien Rouhaud Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Update outdated references to SLRU ControlLock Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6JaDijxyVI95yJZs" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --6JaDijxyVI95yJZs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 01, 2025 at 11:32:41AM +0800, Julien Rouhaud wrote: > Note that the main comment of slru.c still has one paragraph that mentions > "bank control lock" consistently before switching to just "control lock" in the > next paragraph. I'm assuming that it's ok in that context as it seems clear to > me that those are the same thing, just spelled with a less verbose name. Good catch, right. I am not seeing "control" used much as a term (3 times on HEAD). There is a lot of "bank lock" or "SLRU bank lock", both being mixed depending on the parts of the code using SLRUs (multixact, predicates, etc.). "SLRU bank lock" speaks a bit better to me, as the concept relates to.. SLRUs, but that's mostly a matter of taste between the three wordings, I guess. Do you have a preference? Not saying that one is better than the other as they're all used, just noticed the difference in the comments, with all the terms referring to the same thing. -- Michael --6JaDijxyVI95yJZs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmi1KbQACgkQnvQgOdby QH0Y3A/+KVFEF3bZrC6jUmiuEbnpkr1bfbc+Re9tScSH5IIN+mxKuX/09cT07nom N11wKBL2AZhQRKkh7YaMA3CZdROymkFTLDUsMBpwdaaMmxZ7PLi1RpMW67P6gULM KImPcV387HGmXQt0tXtjhPjT/bCwfJXVTjtE4xK+MY+bNkLF0EvFCPMsVw6Wi8sq MIIfu3n6fEeEEOwtNmAzdyFVN79qsJl5sYz7O64rwU2SaeYCITIVHfnLtyGctZyg VWna1qrG6VBn4WKpnQgXhVjqQMRkpzG7fGkQwsOywaJF9nclZbF/mqCsEfVn+JDM xenPWy43VsMaiwS8pvN0xZbhAMROfto8g3D23GZa7yNcuHEx+m4/m2pc/S2dyEeH Zi98K5Rq1QZ26VwIw6tHGK0uNfS7k4IRdzUVSt2aW9FD+GhXClxMXuG2bSMNhXjq DdRLGZziS9cpEmc7cDMH1LP4FpVIVvBCDOoIviJBTi0ISqqXwzj6/0192XmGmGxb G7PTo42v57lVG7WI4bdhfe+n9YqelBmyo1lXi9Hgifs+qBBpzvNyQel2g/XFN6oU KnkLQOfUixkROuNMKBhyjykGPvDWYglbS3AUd8jg+TvFVOcQhQrpTaW5S4ijMSCD FVbI995awQfrN8kKnub9RFwIbBi7G56uXP3tVMGz8I25FeEEhCQ= =d3hJ -----END PGP SIGNATURE----- --6JaDijxyVI95yJZs--