Date: Tue, 2 Sep 2025 09:45:52 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Andres Freund <andres@anarazel.de>,
	Rahila Syed <rahilasyed90@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Improve LWLock tranche name visibility across backends
Message-ID: <aLcDICmlWJbzsE0k@nathan>
References: <aK7PyCbPib+/JO2+@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA5RZ0ve-fHuNYW-ruMwg1y1v7-aCqMm_MiNq1KOdg2Y2-pKDw@mail.gmail.com>
 <aLAFhwpzEwbjiWLG@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAA5RZ0s4ip08Lsk=aYuXGCkBr78jhH=gOau939mhAp-rGuNC3Q@mail.gmail.com>
 <aLCEo0ZMV3vIGRWk@nathan>
 <CAA5RZ0vw-r1qjHw5hUNTzAyCiK3KQ-r+G5ECfWSn+qjdu-fpnw@mail.gmail.com>
 <aLHO-jh-spXWG1pt@nathan>
 <aLJnOnTFSweb2pud@nathan>
 <aLMHVosexT5D-Ybz@nathan>
 <aLVzBrTp731FTw0l@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aLVzBrTp731FTw0l@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/aLcDICmlWJbzsE0k%40nathan>
Precedence: bulk

On Mon, Sep 01, 2025 at 10:18:46AM +0000, Bertrand Drouvot wrote:
> Changes look good.

Thanks for looking.

> Not directly related, but I think that we can get rid of:
> 
> size = add_size(size, LWLOCK_PADDED_SIZE);
> 
> in LWLockShmemSize() and of:
> 
> ptr += LWLOCK_PADDED_SIZE - ((uintptr_t) ptr) % LWLOCK_PADDED_SIZE;
> 
> in CreateLWLocks(), and just make use of CACHELINEALIGN().

Let's take care of the tranche name stuff first.

-- 
nathan