Date: Thu, 4 Sep 2025 21:00:22 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Greg Burd <greg@burd.me>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add tests for Bitmapset
Message-ID: <aLpENihhKL4vOxeX@nathan>
References: <7BD1ABDB-B03A-464A-9BA9-A73B55AD8A1F@getmailspring.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7BD1ABDB-B03A-464A-9BA9-A73B55AD8A1F@getmailspring.com>
Archived-At: <https://www.postgresql.org/message-id/aLpENihhKL4vOxeX%40nathan>
Precedence: bulk

On Fri, Aug 15, 2025 at 11:39:23AM -0400, Greg Burd wrote:
> I noticed that there are no tests for Bitmapset in src/test/modules as
> is the case for other similar things like radixtree, rbtree, etc. so I
> created one.  I realize that Bitmapset is already "tested" by all the
> other code that uses it, but I was able to find one minor oversight[1]
> in that code with these new tests.
> 
> I hope I've covered all the bases, but if you have thoughts on other
> ways to test Bitmapset I'll happily add them to the patch.

Adding some tests here seems like a good idea.  I might look into some ways
to trim it down a bit, but that'd just be minor editorialization.  One
other thing to consider is adding randomness to the tests (see
test_radixtree and test_binaryheap for examples).

-- 
nathan