Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 5 Sep 2025 15:35:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nitin Motiani <nitinmotiani@google.com>,
	Hannu Krosing <hannuk@google.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade: transfer pg_largeobject_metadata's files when
 possible
Message-ID: <aLqEqVAsT1vzorX-@paquier.xyz>
References: <aJ3_Gih_XW1_O2HF@nathan>
 <aLU7AhUFhsJEJ1xB@paquier.xyz>
 <aLcCnNkWtQZ5YQOF@nathan>
 <aLkcuKPYaLJ4RipR@paquier.xyz>
 <aLo7rnQ8MbPK2dGH@nathan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="vy60Z4BAI0+lYpGL"
Content-Disposition: inline
In-Reply-To: <aLo7rnQ8MbPK2dGH@nathan>
Archived-At: 
 <https://www.postgresql.org/message-id/aLqEqVAsT1vzorX-%40paquier.xyz>
Precedence: bulk


--vy60Z4BAI0+lYpGL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 04, 2025 at 08:23:58PM -0500, Nathan Bossart wrote:
> Ah, I'd forgotten about EXTRA_INSTALL.  That simplifies things.  There's
> enough special handling for large objects in pg_upgrade that I think we
> ought to test it end-to-end, so I sneaked it into 006_tranfer_modes.pl.
> WDYT?

Neat.  That works for me.

+        $old->safe_psql('postgres', q|
+            CREATE EXTENSION dummy_seclabel;

Still I think that this bit is going to fail with installcheck,
because src/test/modules/ is not installed by default :)

You can make that conditional with check_extension(), like the tricks
for injection_points in other TAP tests.  The security label creation
and test also need to be made conditional.  The work is already done
with the check on oldinstall, it just needs an extra tweak, so I would
store the condition in a separate variable at the top of test_mode()
in 006_transfer_modes.pl, or something equivalent.
--
Michael

--vy60Z4BAI0+lYpGL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmi6hKkACgkQnvQgOdby
QH1Hnw//RHVHt0u1kHC84syfa89QZkubB+8YzDFQp5H1//VwKl+qsDxH+90AuD9s
8bUVpqBYfQI18RP1Us+LMgZ8ADHyWQCWp9DXiMVjxESMoinuN7p6gg2zAw+tpgrr
uhmE7NAPysL7e61i7zQh+G0/BhjVg+f8mgnpvYDqb/AHNExDLe5kQZsfbkWQVZ7g
Icu8fb5Rpf2JMU8jslbQ+kceh15gMs2++Aa17uLqYoTCl+SodCGrZ2x1MWjb19BQ
rG4/l5cn8N7mWQ5Js4dujO/kRgx7pCc/dYjc+bMcDEzm6bgPKpSlIF9Sq9z1Ebzj
S6Vk+48ahym+3U22Y7Yl8UG/9W8CEbbjuv5YntITlIN8ggaOr5oVhvTaZCKDpnm1
UJlys/8MVm7CgXVkYwpe+MW5dQRYrN5xMOk6Djcg5wpI0GSE+kP/u7VxOAHow4RP
BkiPKryy+inn7Mk6MjWdWwL+Aozr1geo79xbyTFU91yrpUVyW9KY3xVZAVZrjcAC
IIOG6P2Oh8suOrevhqR7AhGlpXi0zmT+q25+nXAl86uqmhdUJpUJt3lVjo2vZLqa
NSV9qGwxWB2j2WAWGSodWRmuspyyl8OoxMS/RjrcDduLudVOnD9s5tcL0R68xa1x
g1CPtBd+nSaxF+fy/swCCQwtYRcMumq8FY8H1dFhHNugzr91jiI=
=xwor
-----END PGP SIGNATURE-----

--vy60Z4BAI0+lYpGL--