Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 6 Sep 2025 10:12:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nitin Motiani <nitinmotiani@google.com>,
	Hannu Krosing <hannuk@google.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade: transfer pg_largeobject_metadata's files when
 possible
Message-ID: <aLuKa8FWd_uMPzSg@paquier.xyz>
References: <aJ3_Gih_XW1_O2HF@nathan>
 <aLU7AhUFhsJEJ1xB@paquier.xyz>
 <aLcCnNkWtQZ5YQOF@nathan>
 <aLkcuKPYaLJ4RipR@paquier.xyz>
 <aLo7rnQ8MbPK2dGH@nathan>
 <aLqEqVAsT1vzorX-@paquier.xyz>
 <aLsoIeIxlCi-L7C_@nathan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="X/C1H3qJH8Bz80LR"
Content-Disposition: inline
In-Reply-To: <aLsoIeIxlCi-L7C_@nathan>
Archived-At: 
 <https://www.postgresql.org/message-id/aLuKa8FWd_uMPzSg%40paquier.xyz>
Precedence: bulk


--X/C1H3qJH8Bz80LR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 05, 2025 at 01:12:49PM -0500, Nathan Bossart wrote:
> How does this look?

+    # We can only test security labels if both the old and new installations
+    # have dummy_seclabel.
+    my $test_seclabel = 1;
+    $old->start;
+    if (!$old->check_extension('dummy_seclabel'))
+    {
+        $test_seclabel = 0;
+    }
+    $old->stop;
+    $new->start;
+    if (!$new->check_extension('dummy_seclabel'))
+    {
+        $test_seclabel = 0;
+    }
+    $new->stop;

Yep.  This plan is safe to rely on.

A tiny comment I may have is that the LO numbers are hardcoded and
duplicated.  I would have used a variable to store these numbers.
Please feel free to ignore my picky-ism.
--
Michael

--X/C1H3qJH8Bz80LR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmi7imsACgkQnvQgOdby
QH2GmA//dlKMxrbWqfv+M9cKtNG59z8knzCe1Jr23xwuz2MTQEef5Z2oSyb0WfQu
wqVphrBnq0otxBiRq27KM+4XiCn4z/fP296HZlFc2gOmd74gwY7q+1AgzYsdmaxI
vZUHNhP9w+C2W/R4IbPLkEu872KAf5Kw+6JcT9aWlJEBtys+E1ATULy00JsJHfsA
HE8c6f/Xz5StZp9jh7ZfZesf3rSzvK61OnQnRj713x4Bv9yRXq3aEefnYILx2lr/
iKXYFfRBACIulLqcuLNW2UbZFTnpEajd4IkrI85Nt5N0EGAuOJ2rY+kXJhKJTkYd
ieDxCno02f3SMyU7h7Pk+cEiVNnuxMdbwWjRr2RiDCzF25xmgC0nXBzlgVPuULqi
oaFhIXGBeg7uvldiaquJXUzChcv3RwQW1N2RWYtLqw+KvfoEWWlG1v8wGrsIVqIq
zfX2PBz6QQ9fWhCD1W+Cw02syWXayrbpC0kGkjVpEKDt54oh3uHOJ3Iync+r11qP
DBFTB16IakRkVn3w9TGOPhhJo9vYCBTXB/t9kTch2TeeZ+lDuUZouOavN1m77g1x
Dlmpi7SzjsAZD40T27lmzihMImDfMOWlj1Oejf5U8nZ/XoS11owI8R22sVCcdknH
bObBdWrG9r4Kk2rYh10s+dmsLuIOnLuNuRWojC7aL1rO3qWNwIY=
=bXEx
-----END PGP SIGNATURE-----

--X/C1H3qJH8Bz80LR--