Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 12 Sep 2025 10:36:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Greg Burd <greg@burd.me>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
	Nathan Bossart <nathandbossart@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add tests for Bitmapset
Message-ID: <aMN5Eu8RjREUpl_F@paquier.xyz>
References: <7BD1ABDB-B03A-464A-9BA9-A73B55AD8A1F@getmailspring.com>
 <aLpENihhKL4vOxeX@nathan>
 <02DB5E92-1E94-4617-AC11-836486F63BD5@burd.me>
 <aLsvPdSHJdRCEk7v@nathan>
 <9E1E0BA4-952C-412A-884A-6E700F26B0CA@burd.me>
 <CAD21AoDijQoXik+U8hf0QptPvNcpjCjfzO_Rp=eCLYSL1D6OOQ@mail.gmail.com>
 <0978d5ba-e015-4889-a8b7-7a2891664492@app.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jEuSsGt3nBYCJ2rw"
Content-Disposition: inline
In-Reply-To: <0978d5ba-e015-4889-a8b7-7a2891664492@app.fastmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aMN5Eu8RjREUpl_F%40paquier.xyz>
Precedence: bulk


--jEuSsGt3nBYCJ2rw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 11, 2025 at 06:56:07AM -0400, Greg Burd wrote:
> Just for reference I started this not to increase coverage, which is a good
> goal just not the one I had.  I was reviewing the API and considering some
> changes based on other work I've done.  Now that I see how deeply baked in
> this code is I think that's unlikely.  Maybe something else distinct for
> bitmaps over 64-bit space at some point will be useful.  I wrote this code
> just to capture the API in test form.

How much does this measure in terms of numbers produced by
coverage-html (see [1])?  The paths taken don't always matter as it
can also be important to check combinations of code paths that are
taken by other tests when checking after edge cases, but that would
give an idea of gain vs extra runtime.  Not objecting to your patch,
just being curious as I am not seeing any numbers posted on this
thread.

[1]: https://www.postgresql.org/docs/devel/regress-coverage.html
--
Michael

--jEuSsGt3nBYCJ2rw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmjDeRIACgkQnvQgOdby
QH2f5A//RsZjl/8HZs/hMNT6LwWxv4CMTQ9gErUmEqb6z38kyM03OFratkwobViw
SWyqqpbGvkSEWQ3poZUjwpEFf7VV9KEFHde1hxphNywSxaW11OHZa6dYwDYUvCgq
JgQsd31ROO9vtLURGFtOregypaJMVIHXWawGdwm0HW70KgCHjPwQfk8SjI8ts/jP
JaMCJ1xySiCCdvQbYKmGBTaoFK+5QFQKk6AcwM8hVMbtN5jwfIUDDppfwrohvfwb
cxmxhPvwOcTeD02h5A9y1f65docZxBNNKntwQsMHefwaZ9LYI23HdxkXa3XSllHO
OqQa/lJUKCAdYeT5hhtID6ihJRcKIuuUunu13d9uDKfYMf1Tyznw97KdDxEKVreW
YZ4xh/V+iLQLlVehTOF/24QdbByaQgDkujzr58/OqP9OVyOiDPRWcwEPKAOfW2Ba
1bhxqwAsndQr7eO6B/5AvdbIdAiWoxPgI3HX/XOOKroH5C6aanxjD/62U4ni0G+4
NzRBAEgYBliWbHpJTKhCStVvSvrgtC+1qxxF50WXl5HNF7kS7mbXSo96lr2hVULm
pJ/dAPAuFmqQvxxwHIn1fTWaVQlGV6pl3ZVZi/UZDypRnljMnTP3XtZLpdkhpmzy
Wpv3bA60tC5gbyPmPnrlrsj20nMaIt6uiHThPoIPc2pIAgY+RFI=
=zgnY
-----END PGP SIGNATURE-----

--jEuSsGt3nBYCJ2rw--