Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v4TtC-00GVDn-2Y for pgsql-hackers@arkaria.postgresql.org; Fri, 03 Oct 2025 00:43:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v4Tt7-00A9kI-NF for pgsql-hackers@arkaria.postgresql.org; Fri, 03 Oct 2025 00:43:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v4Tt6-00A9k9-PX for pgsql-hackers@lists.postgresql.org; Fri, 03 Oct 2025 00:43:10 +0000 Received: from fhigh-a1-smtp.messagingengine.com ([103.168.172.152]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1v4Tt4-0017d6-2A for pgsql-hackers@lists.postgresql.org; Fri, 03 Oct 2025 00:43:08 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 3C59614000B6; Thu, 2 Oct 2025 20:43:06 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Thu, 02 Oct 2025 20:43:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1759452186; x=1759538586; bh=OojcS3Vs84 kYdAR2Diuj5rXVROlcq2wENOgJw1b2o3U=; b=W8lcGaFtoOO7+PbNVSKmvvdIn+ ruuqzyPG1sAm4zUOR7pJE7EBWeI901dYSa/EaN0lt1aLuqhmB7FovXWkYekDZIcf 8+nkXYuqP+4BVoaKrbbwdvCQ3eTVzP0tbgBHDIKJ/2YcICt07SKXUadBRAcWFLbN nJSCBM1FOfsRbgak25Y/rffjacm1m//Ff9ZNThP6ErXdCgYBnJu5ohMFBI266GqY FyhHNpGqvZ+TbveynP7gbz5ydrp6NUNU1FmiO9Zg125HfBhCNERzJJupYFWbbQym DQ444D1N0enhJ6dlrLOUvCZGC1SqNfDYiOemVHICGFsJRWclfczy9MCdJrjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1759452186; x=1759538586; bh=OojcS3Vs84kYdAR2Diuj5rXVROlcq2wENOg Jw1b2o3U=; b=F4MgftxCXQ7iafUtgh7ue6tRe+ya9rSI/muPUe+0gQHtSFGBa8h B6TBpuICvkDXJyRajahUBLia6+uV+Fhrv9BJMlInGLWqQ+oraO0TighAJg5To0SB zveeDpUOL5ZHgbAcR/JxY4FuRYTsMK1k0g6d6DeIRirSRHzbdXyi9gu7qFCg2fwD /iqXoX7fcYRFeoAkljsyJISXgI+/MdhgEyIsUBNip8qUTUTM3XEOprA6/A+4n6AQ r+JPZBDusWJEmz5WwuD83Mt8Mx0M0td9teFDDgJDfihytaBTo9ir5zKRuJN1g9un TYj4lubrwWqezk3bHSzwk+vyKwPnneFKBQw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdekjeeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeggeff hfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegughhroh iflhgvhihmlhesghhmrghilhdrtghomhdprhgtphhtthhopegurghnihgvlheshigvshhq lhdrshgvpdhrtghpthhtohepghhrvghgsegsuhhrugdrmhgvpdhrtghpthhtohepphhgsh hqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Oct 2025 20:43:03 -0400 (EDT) Date: Fri, 3 Oct 2025 09:42:48 +0900 From: Michael Paquier To: David Rowley Cc: Daniel Gustafsson , Greg Burd , PostgreSQL Hackers Subject: Re: [PATCH] Add tests for Bitmapset Message-ID: References: <978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aU2MpxJxJi8o2RCD" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --aU2MpxJxJi8o2RCD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 03, 2025 at 12:36:57PM +1300, David Rowley wrote: > I see test_random_operations() is also strict. Is it worth getting rid > of the SQL NULL checks on the inputs there too? Aka, the attached. Yes, this was not bothering me much. Anyway, agreed about removing these as well. I cannot find an argument in favor of making the function callable on NULL input with default values that are hardcoded internally in the function. Thanks, David and Daniel. -- Michael --aU2MpxJxJi8o2RCD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmjfHAgACgkQnvQgOdby QH0iwg//cNCAgT4OwVh/DCRG/k4vqEPRi1kLjpcn+4VvjfwGaWZkYNUMWK48ngc2 Oh1PMXZyrWan33JTK72RW/IFQk5BXVQ7n4u2dJViGX3FZMbPlozNsC2J+rFBKaVC 5QiiSiuRPJsBq4zCivHoMxH2b7EF8WEqmVjSu/kfam1AxG1yUxLnb5Hb4TFWdcZv Wv6URmeoTMyAbYSA9aM4/aYslwEcOUL237IggJ2yICOKtMcMVVRCqQkFanesOOvr iwnQmmIVP6nlHm0MM4ZA/ZD1a0YHHLvsVgMZYIquijFt1WqyGtp5H7W+rQKVNmal fVf+nd77wYBORQK+dj6Qex++z5W48fDDiMjy6+T7j2CE9ZpANt5nlorRKhu9FU9z JyTprNn3fH6CObM0Z7xY/UZfSZkx8JG65YGHEzjN4Q8C/bp4mhXJYpsGYWYibjAj HDcjrinJpgV89A/TN60rdZk4uuaYgSnnLnjCpXAPwGFGIY3Gyr9RbiL0WMGJ+dhL l4dsZVGcSWrFG0XPnM/nR9VRlMQSXusF4ugU9IEpM0uuuSZ4BlCqSFHR2hUNhyu4 b9SV3yHQ7eMwOBG8gzFqiSX5nX9vFUNN11XiaCakXed5NZKWHpD4LnZOTiZBHrYO 7jQMAyl91IztphiA1XzaBmMdkYYEUgy+VBfyzCC90qvICUU73UI= =s5ed -----END PGP SIGNATURE----- --aU2MpxJxJi8o2RCD--