Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 23 Sep 2025 20:07:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Greg Burd <greg@burd.me>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Robert Haas <robertmhaas@gmail.com>,
	Nathan Bossart <nathandbossart@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>
Subject: Re: [PATCH] Add tests for Bitmapset
Message-ID: <aNJ_YTuFnMn23PEI@paquier.xyz>
References: <aMz57nHgkLozddYu@paquier.xyz>
 <CD368B71-2947-407D-8967-181A4CB4A985@greg.burd.me>
 <aNEBUeYqqSVOSVaP@paquier.xyz>
 <3027069.1758606227@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="W6Pl0JLkymAph1EC"
Content-Disposition: inline
In-Reply-To: <3027069.1758606227@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/aNJ_YTuFnMn23PEI%40paquier.xyz>
Precedence: bulk


--W6Pl0JLkymAph1EC
Content-Type: multipart/mixed; boundary="cARV34OOUCvkdZPx"
Content-Disposition: inline


--cARV34OOUCvkdZPx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 23, 2025 at 01:43:47AM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> The result I had was good enough, so applied.  The CI was OK, the
>> buildfarm may have a different opinion.
>=20
> This patch seems to be rather full of arbitrary casts to or
> from Datum, which is no longer okay.  You need to be using
> the appropriate conversion macros, such as PointerGetDatum.
>=20
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dmamba&dt=3D2025=
-09-23%2002%3A12%3A36

Right, this can ve reproduced with a -m32 added to gcc.

I don't see a need for a Datum manipulation in these conversion
macros, as we already allocate the results to and from "text"
before/after using the GETARG or RETURN macros.  Using directly
text_to_cstring() and cstring_to_text() takes care of the warnings, as
well.
--
Michael

--cARV34OOUCvkdZPx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="test_bitmapset-warnings.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/test/modules/test_bitmapset/test_bitmapset.c b/src/test/mo=
dules/test_bitmapset/test_bitmapset.c
index 61f256f65a44..f5473e58ce8e 100644
--- a/src/test/modules/test_bitmapset/test_bitmapset.c
+++ b/src/test/modules/test_bitmapset/test_bitmapset.c
@@ -84,8 +84,8 @@ PG_FUNCTION_INFO_V1(test_random_operations);
 	} while (0)
=20
 /* Encode/Decode to/from TEXT and Bitmapset */
-#define BITMAPSET_TO_TEXT(bms) (text *) CStringGetTextDatum(nodeToString((=
bms)))
-#define TEXT_TO_BITMAPSET(str) (Bitmapset *) stringToNode(TextDatumGetCStr=
ing((Datum) (str)))
+#define BITMAPSET_TO_TEXT(bms) cstring_to_text(nodeToString((bms)))
+#define TEXT_TO_BITMAPSET(str) (Bitmapset *) stringToNode(text_to_cstring(=
str))
=20
 /*
  * Individual test functions for each bitmapset API function

--cARV34OOUCvkdZPx--

--W6Pl0JLkymAph1EC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmjSf2EACgkQnvQgOdby
QH0cXg//bgSwpGAaUL/Q/E4xkaVNZ9unJFWNTLQbzzPKWaGtN0udhJqYLljA2wN4
pn0RXxUhqZMy7LwdugcRpl+RJUhr0yE5srNbEXGZ2epSd/JwUgC2Fy+99ygF51RS
+f+iu20gbzSLP9SaaOOIiC1vLHADhMI88qTHYqmy5hER5L8UloI9U3MMWjKzzxiP
eBKvm7gwKADmBYSfjz/Amhpa3QyumcVAJFXE/o+tuBPv53UOvy/GvnS6fyyxEKCS
J5lUrErZlS0eKpenQ5nYtQFr1M4orwVSwc6XjXZBFiGGh3vkK2jfqeqtoMDaf2j0
7Iis7TZ1PG8dnxIfMMj6/iAN0BCUrVDqVFx4hWwqAc4TAo1udSQTTMaU59jVX5gl
7Z4BvzHuzpL3ukbLnx+IP13UERTzoK5JPC5ugYU6XbBi3TO02X3pHod6og85rx8Z
xRyLdbW1I0WDxneNis4aFT1TN/oLxaNJAKXi6MflEUIrBWiXPS67/xxTqJh5xED0
Oi0neddT+SQopgqVTU1yOFFYUqdvwsmUywgTDkn8l+6gmgoV1Oxn7Z9dP0/EDYUp
TCJd7Sct71HiuOvzdmCoG9NSLwO8l+xYBMm5p57C8V6k/M3EgtqxZ1OS7Qt0hefG
jqvebTpKnqMq7R+K12Hkf/yJm6btoSxw58mn3IyuC4uzwdMeXkI=
=Uy9z
-----END PGP SIGNATURE-----

--W6Pl0JLkymAph1EC--