Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 25 Sep 2025 08:28:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Greg Burd <greg@burd.me>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add tests for Bitmapset
Message-ID: <aNR-gsGmLnMaNT5i@paquier.xyz>
References: <aNMr3gykF8rfJxry@paquier.xyz>
 <20A8207F-B849-40B4-821D-8D334C101DCD@getmailspring.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jKcSg4kTLdAkg9hU"
Content-Disposition: inline
In-Reply-To: <20A8207F-B849-40B4-821D-8D334C101DCD@getmailspring.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aNR-gsGmLnMaNT5i%40paquier.xyz>
Precedence: bulk


--jKcSg4kTLdAkg9hU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 24, 2025 at 07:39:59AM -0400, Greg Burd wrote:
> Thanks Michael, Tom, for the help getting this into shape and in the tree.

By the way, Greg, do you think that we should aim for a state where we
are closer to completion?  We have the module up to the point where we
are in pretty good shape, with most things and the infrastructure done
but it can be improved a bit more, as well.=20

Based on the information provided by the coverage report at
https://coverage.postgresql.org/src/backend/nodes/bitmapset.c.gcov.html,
we still have the following things:
- bms_equal for different word counts
- bms_union, bms_nonempty_difference, bms_is_subset and bms_intersect
with shorter word counts.
- bms_different with different word counts
- A couple more cases with bms_subset_compare
- bms_member_index and word counts
- bms_overlap_list with negative number in input list.
- bms_singleton_member ERROR with empty input.
- bms_get_singleton_member with NULL input
- bms_del_member with word counts
- bms_replace_members and repalloc case
- bms_add_range, bms_join and bms_del_members, more word count cases
- bms_prev_member and the prevbit business

There is not much we can do with the random function, still we could
do something about the NULL paths in the internal functions:
https://coverage.postgresql.org/src/test/modules/test_bitmapset/test_bitmap=
set.c.gcov.html

The coverage of the latter matters less than the coverage of the
former, of course.
--
Michael

--jKcSg4kTLdAkg9hU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmjUfoIACgkQnvQgOdby
QH0lBw//Uk76j9UZjOuYsLT/7a76v84zV1h01AhbVPR3jAGJUkOqdicwe0/bl1TB
zGR11WwQ6FqK5UqlGKzNvn7uZ3sJsvrR9X+gATh2DxwjTv81w6F2f3eiCmcMFXFn
/oGtG5Soa/iWeEfTsAAW8Vm+X27+e8P8+JWrK+Tt5MHLNSZTxvOG2eBKncyjD3q7
A/eHxk4ld3oLWe1Rt6XeUF8LQQH5hxNTj4gLUxS1TzOLB2IU1lhhYezOApZP5gAg
NC6S7+p/iwMmmdQfFEGIhKxYPNzy7rg0a8S1PNsaVDin287SzFeye21qaQ0DoVi+
uFjIDt7li30MNs5egFge2CM1WSAjQiZUOsaPU3/0RSLOAmjmP9cZR4pXQXc40F7h
bD45LBXSy5aafgxfoOKOfAqFsTYfI+fduDJbGWHMI989V2EsNCoIBb08GaXqdMqx
afbFzyy6cuvfs4oLNoHbBB8VTELvaYiCJ5+aIlR16SefryQqJPtdb6fM3U0L0TyL
uLtayIPhz0g/6iv7EYZTkl2wGUgNC+grgqxTWplt+wz+56+pbFZpHFTxeGWPFK0H
pkzQ93i/WByeaLgL4tWR1oih1Nk/hEkfqltKSwI9Dp2e412PfvCqIQZstoaDXsso
DRRVVzeXF5VPB+u182xE04SH/jorbZgKImxqIEHcSv6hD0vb024=
=rB6l
-----END PGP SIGNATURE-----

--jKcSg4kTLdAkg9hU--