Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v3NTj-00FH2E-GM for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Sep 2025 23:40:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v3NTg-004i25-LT for pgsql-hackers@arkaria.postgresql.org; Mon, 29 Sep 2025 23:40:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v3NTf-004i1x-SO for pgsql-hackers@lists.postgresql.org; Mon, 29 Sep 2025 23:40:21 +0000 Received: from fhigh-b3-smtp.messagingengine.com ([202.12.124.154]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v3NTd-000nLz-0p for pgsql-hackers@lists.postgresql.org; Mon, 29 Sep 2025 23:40:19 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id 334B27A0133; Mon, 29 Sep 2025 19:40:14 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Mon, 29 Sep 2025 19:40:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1759189214; x=1759275614; bh=JS/OcLgbLj DfY/AjtdNiga0f30n9iXpxFuPvEVcrolY=; b=MK7gT7SEIJquUvqHHxNMKc525o LUSo064iOSlH2N4JYerD3SQgkW9e30EtEYpGebEJx+dzpvGs2vSIpoUbfgv8ThEa +sGhkZ52eZLLLYqgSQKfkfgpcL9iiWosNqxNF/Im5pzjc9pqpszC7qQQHK9Moi6s rsVTO2pN0HarX5BNRj/f4TbT0SXMFWu28LojgWnXfL847xatu3J/ODHgfKRoqq2q 3LQCdqiOVFfyhaogiTYFOtDHuRUgAczjzBbC1fSDxn/Ol3n0Zjl9+vFiGlyRu15Z AH4QKHHrCFNWqZrSH+AFB4j8ClRbVeukqwjBE1yOS0NNecAKECjfT6CH/xqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1759189214; x=1759275614; bh=JS/OcLgbLjDfY/AjtdNiga0f30n9iXpxFuP vEVcrolY=; b=brkpE0LBMyTbDN3i/Y6Fwf0mjez6YPILSxDPhobA04U9dZ4TTQl leUaS4YQ/IVDv3UFjmWCaonqI6uJXYVxsz3BtWzqD2iV2/6h2laWRpr1twRwriFw HJwIMBSwD57XN2+ToZ0cb0qGyV8L0duoqREtrqxYrllq+lfivkGdws4ZAfZNTa/0 3jkmKf16eDqadKl1At2QSw+gSnxQ72QxpzhnrF0/uTBDw5LsLPlHiAJPYr1MBV7G +upvmlnCKcCm9iI2svwtb9N03ZFg7SrtBASepW+gJarwILgEQm9h2gB7L7oFtqJO gI0BweqHjUZu7RcLj+vbtIVgou9GWlMi3xA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdejleefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeggeff hfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehgrhgvgh essghurhgurdhmvgdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhs rdhpohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Sep 2025 19:40:09 -0400 (EDT) Date: Tue, 30 Sep 2025 08:39:56 +0900 From: Michael Paquier To: Greg Burd Cc: PostgreSQL Hackers Subject: Re: [PATCH] Add tests for Bitmapset Message-ID: References: <791EFF06-DE5A-4E91-83E1-4C35550B55DA@getmailspring.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="E2EMoq2sPEAeCWCr" Content-Disposition: inline In-Reply-To: <791EFF06-DE5A-4E91-83E1-4C35550B55DA@getmailspring.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --E2EMoq2sPEAeCWCr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 29, 2025 at 06:27:01AM -0400, Greg Burd wrote: > Yes, I think that does it. Thanks so much for the guidance and help > taking this to its logical end. I greatly appreciate your guidance and time. The latest coverage report confirms 100% for bitmapset.c The only two code paths I'm seeing as not covered are: - test_bms_add_range() for a bms_free() case. - test_bms_make_singleton() on NULL input, because the function is created as strict: =# select proisstrict from pg_proc where proname = 'test_bms_make_singleton'; proisstrict ------------- t (1 row) I'm not planning to bother about these, so we are good here. -- Michael --E2EMoq2sPEAeCWCr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmjbGMwACgkQnvQgOdby QH2iBBAAqnDviDfGlJ5DuL7MHCOE9gByuGg/4521rg4oMKz6dkHAaYrvzxXA3sD3 USt91n3EzOGrrMmUy6CznwIwFY7h5SoA/f71vPliKAOscaKBPUXY8quka8+UTllx N4OZARL3Dh1IVGpavG1jANGCuhCHE7bVp/Op7hU3yAgpOHRh5jZMHDnulUz1k6ld i2oB8lFasJ6RZ6Gy+qa7oFwtlmp4p2F1rDSQdNs6IML/HW36QiMIsPwGtWj3n67w SpfyeOyjSd+wMOO9bST/0xqx7GIa8FnpTD3zoLqMU4vIlBKjK669lCjiF7bL5CAd d2M9om8gth1UrX4DsUvykf6izxoXHWcUL85/CMu3rHpx5AQmLpvt8ctR8noY/Fuv ZrWpr+5CD3aRga8agITinp5iSyWcJZy7OpRkQJ85czg41PU58kx6Mm9h1B9n1DuL tC1zKrwMIBRTXTbG4Lu3AVEJL3qdgekd65YxgwSYgJdQrSRPWyj9b0cEQobhpAr9 jh9KWidwGM01gQaYqGW9pg/CPFu6PX6YI6n5MWcpAq97jVxCW55s/Lf7YhyA6wp5 5C9AxM+U4261/qSrsFxAhdL9QLvXT7VlAWaib8vPfLB4p3ojeeTXv4iBSbNZPihD d/eXyoHljcyu/kfdpebXi21FuCX+qfkRJNugyx6RAfW8HYgb7eU= =Wy9+ -----END PGP SIGNATURE----- --E2EMoq2sPEAeCWCr--