Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v3Oaa-00FYOy-GS for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Sep 2025 00:51:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v3OaX-0054bp-5h for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Sep 2025 00:51:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v3OaW-0054bh-SZ for pgsql-hackers@lists.postgresql.org; Tue, 30 Sep 2025 00:51:29 +0000 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1v3OaV-000bcv-0f for pgsql-hackers@lists.postgresql.org; Tue, 30 Sep 2025 00:51:28 +0000 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id 25D16140002C; Mon, 29 Sep 2025 20:51:27 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Mon, 29 Sep 2025 20:51:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1759193487; x=1759279887; bh=q1acgoQB28 R4eQJzeRL/KsniPyZwla5NE6bx4ylpX70=; b=XAAJ7Ikmol1IqgggiSUaHxnzN7 Frrg/Uyif1NmxwlVsLIeuI3Hni9ffgiLo2r/sZh65h1CARq2iq8NT8I78AGl+6Uf 5FkLwJWiit+D5KD2sdSVJmJCm/3yP7+Wawvk8pOerQSCQuDs2psLa5H3AhmJo3QF aeQ5/6oC7HOGaTckYz/JX7UrjzuO4txSDiwdV4g1jLjaSiNKnRfGY0gGWdDXnDC3 e7vGo/vavThmvslXNjoGZeqSu6jzmAUrJi4nLSITFDuWJeWvGT5X6aQZJU0hsZ0C nO2Mij3oeraIMxOpdd244lyzdsZac3jn1D3Iq4F7mdpAYYu/5LJ3fFSVWCjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1759193487; x=1759279887; bh=q1acgoQB28R4eQJzeRL/KsniPyZwla5NE6b x4ylpX70=; b=sDPYUGL/aOlY4euu/0DJhFa2C9CXALabHhCmZaqs2CoA8vbvr6C opgsjfCYg1G10M2mYeZQNoNzHuiyKgXSCe1Vu58OYSZfP6VW+m2s8rvSBLpyGQEJ u0WtatmeuYNGXLULG1JV1DEWabm/IdA8B8QHUcyLOJEbbTU75fDRKKeIcj1WJu2J VX+yaHJje9xJA85EZHkit0D1gZGD+YrqhhO6bKF+kwjp8rBply875FG/N7fQpbKf dyFtczrDSlj/QGAjzVPhyMh+iUK67Lrz5eyGnZ5VL2efF+jic5iSnZpi/tFrBpFa ZbSoQn/HitnLT8wORj2fGKycUtYiao/6tJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdejleeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlh cuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvden ucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquh hivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeggeff hfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipdhn sggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegughhroh iflhgvhihmlhesghhmrghilhdrtghomhdprhgtphhtthhopehgrhgvghessghurhgurdhm vgdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrh gvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Sep 2025 20:51:25 -0400 (EDT) Date: Tue, 30 Sep 2025 09:51:03 +0900 From: Michael Paquier To: David Rowley Cc: Greg Burd , PostgreSQL Hackers Subject: Re: [PATCH] Add tests for Bitmapset Message-ID: References: <791EFF06-DE5A-4E91-83E1-4C35550B55DA@getmailspring.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Y3OON/Hyugr+jpsh" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Y3OON/Hyugr+jpsh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 30, 2025 at 01:19:05PM +1300, David Rowley wrote: > NULL is a valid Bitmapset, so I don't really see the need to check for > an empty set before calling bms_free(). If those were removed, then > you'd not have to care about the coverage of that line. Yeah, we could just remove them as you are suggesting, as well. -- Michael --Y3OON/Hyugr+jpsh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmjbKXcACgkQnvQgOdby QH3F0Q//Xe/JwbaZum/MIPCpfhCE08ndeKK1jaSAtU45nkg5bpvmEC3TLbEov2tI ySC7TyNC+y65hZ9tmBCA2OmGP2seDn2UbBOYI4B83ktS989HXb0gPFYwgxX1rqOi wfwiPu1gWx0KpaGK64QBrOfaTZz6NdPbC62jUwN9keoEysbhgp0J16YiwYH2o7pD Lchcm9sac5xp2aBMMQSoT1MHo97+3T0QTRGT5XHYOIoMKkolaXSJADQUaYj4sOKI 7JL1+Opvy/OyUvKx67LGuXg0WajYOeCpWlU6hHbNVme15sEQcnRmvz+Nd/KD/FaL TycCNk5TDU3HD+F9uf6WU8X43K/+fF3ua5xw3NrnS6aPY3EWda1GjkmREsroVDOQ FqMh0iZeaSJq6CbOcHV/KwtyLalpaZ7HZAqURpF34Olvw3jNgln5sq8X0d0cmbUM XxAdP74RsBuVQKmn/1hJ6EJSXUqiO6lNDkAaRessyR6wgwsJJjBxaRVa0LVyTXZe ORwKoQ73s4NVzUMqBBfgbd/D2u4tIzxfAK0EuntoEdszohzdSAphTjOKKb8JBXxy 409DwQMZsZqEUT4u4+pFvVn/sMfjzznBuY3owsQTZk/Xz3ghkuqSRcuBZZCJ2Bhd L06PdYj/2/vdWrY3f3FyDlpN7krqPd1aU0+g8BiCFAJMCYVl/Uk= =w9Af -----END PGP SIGNATURE----- --Y3OON/Hyugr+jpsh--