Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 1 Oct 2025 14:14:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Greg Burd <greg@burd.me>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add tests for Bitmapset
Message-ID: <aNy4xV4Fa1m9lyXX@paquier.xyz>
References: 
 <CAApHDvq-4994jpDnspQ+bgSbzo0+=Z4YQbj+YfP7wi97B0e1qg@mail.gmail.com>
 <76DBEF5D-EA47-4C30-8D28-97B3B88E2E2D@greg.burd.me>
 <CAApHDvrvixMmscGEfEyYz0=qbwzM7Y0Up-Uh_AKVmfn8K2sn_A@mail.gmail.com>
 <aNxpxE6a9G3sbfrm@paquier.xyz>
 <CAApHDvoC-W3s2QJdBY6B32BXy2br9iGsNJ3v4uLFOosBgmY2YA@mail.gmail.com>
 <aNyiu0fKRqihdwpV@paquier.xyz>
 <CAApHDvrEPw6DAQdZg7u1YknVvN1Gy38kUURQm8bOHSKU2cw+4w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="80ZkXVPIPoNKgDby"
Content-Disposition: inline
In-Reply-To: 
 <CAApHDvrEPw6DAQdZg7u1YknVvN1Gy38kUURQm8bOHSKU2cw+4w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aNy4xV4Fa1m9lyXX%40paquier.xyz>
Precedence: bulk


--80ZkXVPIPoNKgDby
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 01, 2025 at 06:00:59PM +1300, David Rowley wrote:
> I didn't look at the coverage report, but on thinking about it,
> test_bitmapset.c's "PG_RETURN_NULL(); /* invalid input */" won't be
> covered as I stripped out all the tests which purposefully pass
> invalid input. You may not want it that way if you're keen to keep the
> coverage of the test module high as well as bitmapset.c

Yes, that's something I was just going through, with a result pretty
close to what you have sent, including the removal and replacement of
most of tests that were specific to the test module.  The prev/next
member coverage is still looking OK from here, though.

Thanks for the typos, I've missed these.
--
Michael

--80ZkXVPIPoNKgDby
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmjcuMUACgkQnvQgOdby
QH1TIw/+KhWZGj88it5Fi6T1n7N34MEfLZncKhABmTh768t5nbmUKpHQnBSXKMkG
xiqLJupmPjZ0JeZlyqx+Owct4dsIKxt6zgyrn4HdYjgtLWoKXTmKJto1e8TtuElp
xW9Qc6C8ZYIfbu8Oo1dEdFqcVKsjIbaK91ZaJrb9Sio+fLoU3yqLONndOvh4c23l
mGBM7H+VS6JXB2LoKiKxIHxgXHB+4DXtMGm6ZtWDkd+mgQKDcRrciQqTnY+JcOOJ
7SAh+Dk9DeWd/L2w//TWQYQ7OqWu6qfunf7aCJHhM1NwDco0Q/eFFBfPjpwCuYGw
ZKYDOcW2KDkElLtAWCzRQNy2xAOlQHpbBsFGGnuNT0fXgi0bxiK2RCib8lHHg1hC
oAxuQCfocrQH5U5QIKtpwzY7/cX2UVsul/9mBUSYh2mcbt+r2Tyzp5tSy3V6ujnb
WeDcfu2GhVjnIpXC27tRa90H1FjNVGAdZuKChTMg+A91uxQmtPTm8ER3W7JBaYI5
Mi4o/YjPDTtBQROE3kH6ypQfSQ+8UknIm+a1MLrWmCx9JYwpiXukKSOABIQVDIM2
CY4ZdYyXTxvBMXjM/Zn92P1t4+oA4hofj3a3MUCawBgfXEWoIKGMN3mMjFij6X+3
Sbs+EfB67+d7iG49OgHTvYgR8EZGULawzh9CicJFB8Iayzc4xXo=
=LQlT
-----END PGP SIGNATURE-----

--80ZkXVPIPoNKgDby--