Date: Fri, 10 Oct 2025 11:26:08 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Ayush Vatsa <ayushvatsa1810@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Clarification on Role Access Rights to Table Indexes
Message-ID: <aOkzoH-pXdBr0ewf@nathan>
References: <Z8zwVmGzXyDdkAXj@nathan>
 <279947.1741535285@sss.pgh.pa.us>
 <Z88CB-vDehJ9rW8u@nathan>
 <aNQVIVKarUipPcnW@nathan>
 <3432170.1758730414@sss.pgh.pa.us>
 <aNQhuRQfD3PlpeuT@nathan>
 <8af53c6e8992aa706e63aafe60a3bcf100b524d1.camel@j-davis.com>
 <7b0e2774cdcc8f522ac82f64a8d7266f353a5094.camel@j-davis.com>
 <aOfXNAFkj_EFm-8q@nathan>
 <aOgmi6avE6qMw_6t@nathan>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="fHRxQ/rtkbDAFFP4"
Content-Disposition: inline
In-Reply-To: <aOgmi6avE6qMw_6t@nathan>
Archived-At: <https://www.postgresql.org/message-id/aOkzoH-pXdBr0ewf%40nathan>
Precedence: bulk


--fHRxQ/rtkbDAFFP4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 09, 2025 at 04:18:03PM -0500, Nathan Bossart wrote:
> There's a similar pattern in get_rel_from_relname() in dblink.c, which also
> seems to only be used with an AccessShareLock (like pg_prewarm).  My best
> guess from reading lots of code, commit messages, and old e-mails in the
> archives is that the original check-privileges-before-locking work was
> never completed.

I added an 0004 that changes dblink to use RangeVarGetRelidExtended().

> I'm currently leaning towards continuing with v4 of the patch set.  0001
> and 0003 are a little weird in that a concurrent change could lead to a
> "could not find parent table" ERROR, but IIUC that is an extremely remote
> possibility.

After sleeping on it, I still think this is the right call.  In any case,
I've spent way too much time on this stuff, so I plan to commit the
attached soon.

-- 
nathan

--fHRxQ/rtkbDAFFP4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v5-0001-fix-priv-checks-in-stats-code.patch