Date: Mon, 27 Oct 2025 16:00:01 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: Fujii Masao <masao.fujii@gmail.com>,
	Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
	Greg Sabino Mullane <htamfids@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: display hot standby state in psql prompt
Message-ID: <aP_dUTvY6a34RqJH@nathan>
References: 
 <CAKAnmmJD=hCvFes5mrcn_PdmY5C8sioWxSoN_jzikZrrSeOMkw@mail.gmail.com>
 <7b2bd420-9687-4dc3-b5a7-51a24646a5f1@uni-muenster.de>
 <CAFC+b6oEYiW4Nh7vVWyYi5n6g1ac2=E71JP5NaoT2ARjzsTR6g@mail.gmail.com>
 <9d45ca06-cd8b-44bc-9647-c7dd5f4595cd@uni-muenster.de>
 <CAHGQGwHnx96uspkmOsrpytew0A25wm4ozpe2=GzZpHoAph+t0g@mail.gmail.com>
 <c7748940-b2f6-4022-8c80-66dd8304c42e@uni-muenster.de>
 <CAHGQGwHzNr71zQ7i73Jt55gnW0D-DYJtdoXHKEs0BgsjXAXw5Q@mail.gmail.com>
 <bc9be152-ca08-41f1-800f-d78fd38c75cb@uni-muenster.de>
 <aP-ccJv1iyOmrieo@nathan>
 <171b207e-8fb4-44bb-b6a3-9a12c5a9625b@uni-muenster.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <171b207e-8fb4-44bb-b6a3-9a12c5a9625b@uni-muenster.de>
Archived-At: <https://www.postgresql.org/message-id/aP_dUTvY6a34RqJH%40nathan>
Precedence: bulk

On Mon, Oct 27, 2025 at 09:17:03PM +0100, Jim Jones wrote:
> On 27/10/2025 17:23, Nathan Bossart wrote:
>> This was briefly mentioned upthread, but I'm a little concerned that this
>> doesn't respond to commands like SET TRANSACTION READ ONLY.  I wonder if we
>> should mark transaction_read_only as GUC_REPORT and use that instead.  FWIW
>> I see that we marked search_path as GUC_REPORT somewhat recently (see
>> commit 28a1121).
> 
> You're right, it doesn't. I like the idea, but I'm not sure how to
> integrate a transaction-scoped variable into this feature. Would that
> mean we also need to change the reset mechanism for GUC_REPORT variables
> when the transaction ends?

Hm.  You're right, that seems to have problems (I'm curious about the use
of stmt->is_local in SetPGVariable() for SET TRANSACTION statements).  I
also see some past discussions in this area [0] [1] [2].

[0] https://postgr.es/m/flat/3a40f835-116d-0f95-aede-d5236337bbf0%402ndquadrant.com
[1] https://postgr.es/m/flat/CA%2BTgmoZsHrHeqh5dYpoH%2BWW5EmT-egMGuyrLTsjKz80WajT4tg%40mail.gmail.com
[2] https://postgr.es/m/flat/CAFj8pRBFU-WzzQhNrwRHn67N0Ug8a9-0-9BOo69PPtcHiBDQMA%40mail.gmail.com

-- 
nathan